From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
aalbersh@kernel.org, cem@kernel.org, hch@lst.de,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 07/26] xfs: hide b_flags manipulation from code outside of xfs_buf.c
Date: Mon, 12 Oct 2026 08:44:05 -0700 [thread overview]
Message-ID: <as0ARZpyuDQYbqCa@infradead.org> (raw)
In-Reply-To: <20261012153503.GY2705364@frogsfrogsfrogs>
On Mon, Oct 12, 2026 at 08:35:03AM -0700, Darrick J. Wong wrote:
> > propagating the kernel flag to the libxfs one might be a good idea.
> > But please don't hide it in the resync, but make it an explicitly
> > documented separate patch so that it is properly described and
> > easily bisectable.
>
> Hrmm. Looking at the existing XBF_DONE usage in libxfs:
>
> libxfs/rdwr.c:1428: * The buffer must be XBF_DONE prior to the call. Afterwards, the buffer will
> libxfs/rdwr.c:1437: ASSERT(bp->b_flags & XBF_DONE);
> libxfs/xfs_platform.h:323:#define XBF_DONE 0
>
> I'm gonna guess that if I replace the helper with:
>
> static inline void xfs_buf_set_uptodate(struct xfs_buf *bp)
> {
> /* does nothing, XBF_DONE is not LIBXFS_B_UPTODATE */
> }
>
> Everything will be all right. How's that sound?
For this series right. But as argued by the repair log recovery
slop series unifying the flags is probably a good thing, just not
hidden in a resync.
next prev parent reply other threads:[~2026-10-12 15:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 23:45 [PATCHSET 1/3] xfsprogs: new libxfs code from kernel 7.3 Darrick J. Wong
2026-10-09 23:45 ` [PATCH 01/26] xfs: add xfs_metadir_create_file helper Darrick J. Wong
2026-10-09 23:46 ` [PATCH 02/26] xfs: create quota metadir inodes using xfs_metadir_create_file Darrick J. Wong
2026-10-09 23:46 ` [PATCH 03/26] xfs: create rtgroup " Darrick J. Wong
2026-10-09 23:46 ` [PATCH 04/26] xfs: mark internal metadir file creation helpers static Darrick J. Wong
2026-10-09 23:46 ` [PATCH 05/26] xfs: use kmalloc_objs() instead of kmalloc() in xfs_da_grow_inode_int Darrick J. Wong
2026-10-09 23:47 ` [PATCH 06/26] xfs: remove spurious XBF_DONE clearing on readahead validation failure Darrick J. Wong
2026-10-09 23:47 ` [PATCH 07/26] xfs: hide b_flags manipulation from code outside of xfs_buf.c Darrick J. Wong
2026-10-12 13:21 ` Christoph Hellwig
2026-10-12 15:35 ` Darrick J. Wong
2026-10-12 15:44 ` Christoph Hellwig [this message]
2026-10-09 23:47 ` [PATCH 08/26] xfs: validate attr entry pointer before field access Darrick J. Wong
2026-10-09 23:47 ` [PATCH 09/26] xfs: don't hold buffer locks across sync transaction commit in xfs_sync_sb_buf Darrick J. Wong
2026-10-12 13:22 ` Christoph Hellwig
2026-10-12 15:36 ` Darrick J. Wong
2026-10-09 23:48 ` [PATCH 10/26] treewide: refresh kmalloc_obj() conversions Darrick J. Wong
2026-10-09 23:48 ` [PATCH 11/26] xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN Darrick J. Wong
2026-10-09 23:48 ` [PATCH 12/26] xfs: initialise error in xfs_defer_finish_one() Darrick J. Wong
2026-10-09 23:49 ` [PATCH 13/26] xfs: give the deferred barrier op type a name Darrick J. Wong
2026-10-09 23:49 ` [PATCH 14/26] xfs: report the error that made deferred work shut down the fs Darrick J. Wong
2026-10-09 23:49 ` [PATCH 15/26] xfs: correct the parent pointer space reservation comment Darrick J. Wong
2026-10-09 23:49 ` [PATCH 16/26] xfs: initialise args->total for parent pointer updates Darrick J. Wong
2026-10-09 23:50 ` [PATCH 17/26] xfs: assert the reservation covers each da fork growth Darrick J. Wong
2026-10-09 23:50 ` [PATCH 18/26] xfs: fix the rtrmap and rtrefcount _maxlevels_ondisk functions Darrick J. Wong
2026-10-09 23:50 ` [PATCH 19/26] xfs: fix xfs_rtrmapbt_mem_cursor for non-rmap filesystems Darrick J. Wong
2026-10-09 23:50 ` [PATCH 20/26] xfs: preserve owner on in-memory btree creation Darrick J. Wong
2026-10-09 23:51 ` [PATCH 21/26] xfs: don't leak new_bp if xfs_btree_bload_drop_buf fails Darrick J. Wong
2026-10-09 23:51 ` [PATCH 22/26] xfs: fix under-reservation of blocks when repairing sf directories Darrick J. Wong
2026-10-09 23:51 ` [PATCH 23/26] xfs: remove duplicate INO1_WRITTEN check Darrick J. Wong
2026-10-09 23:51 ` [PATCH 24/26] xfs: fix typos and repeated words in comments Darrick J. Wong
2026-10-09 23:52 ` [PATCH 25/26] xfs: don't let hidden_space go negative in xfs_metafile_resv_init Darrick J. Wong
2026-10-09 23:52 ` [PATCH 26/26] xfs: fix wild memcpy access when formatting ondisk rtrefcount btree roots Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as0ARZpyuDQYbqCa@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox