From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Andrey Albershteyn <aalbersh@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] libxfs: fix compilation errors
Date: Wed, 14 Oct 2026 11:24:09 -0700 [thread overview]
Message-ID: <as_IydSHaWCYgnLJ@infradead.org> (raw)
In-Reply-To: <20261014174442.GK2705364@frogsfrogsfrogs>
On Wed, Oct 14, 2026 at 10:44:42AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Add includes to eliminate warnings from -Werror=missing-prototypes.
> It's not a good idea to let the compiler apply the default function
> declaration.
What do I need to do to see these warnings? I'm getting a few warnings
at the moment (and plan to look into them), but they are entirely
different:
xfs_alloc.c: In function '__xfs_free_extent':
xfs_alloc.c:4017:41: warning: variable 'busy_flags' set but not used [-Wunused-but-set-variable=]
4017 | unsigned int busy_flags = 0;
| ^~~~~~~~~~
xfs_bmap.c: In function 'xfs_bmapi_convert_one_delalloc':
xfs_bmap.c:4360:33: warning: variable 'flags' set but not used [-Wunused-but-set-variable=]
4360 | uint16_t flags = 0;
| ^~~~~
xfs_log_rlimit.c: In function 'libxfs_log_get_max_trans_res':
xfs_log_rlimit.c:162:33: warning: variable 'i' set but not used [-Wunused-but-set-variable=]
162 | unsigned int i;
| ^
2345 translated messages.
3139 translated messages.
prefetch.c: In function ‘do_inode_prefetch’:
prefetch.c:1027:33: warning: variable ‘queues_started’ set but not used [-Wunused-but-set-variable=]
1027 | int queues_started = 0;
| ^~~~~~~~~~~~~~
btheight.c: In function ‘construct_records_per_block’:
btheight.c:158:11: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
158 | p = strchr(tag, ':');
next prev parent reply other threads:[~2026-10-14 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 17:44 [PATCH] libxfs: fix compilation errors Darrick J. Wong
2026-10-14 18:24 ` Christoph Hellwig [this message]
2026-10-14 18:42 ` Darrick J. Wong
2026-10-15 5:56 ` Christoph Hellwig
2026-10-15 5:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as_IydSHaWCYgnLJ@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox