Re: [xfsprogs] mkfs: fixup memory leak on exit

[Christoph Hellwig <hch@infradead.org>]

On Tue, Oct 06, 2026 at 07:48:51AM -0700, Darrick J. Wong wrote:
> 
> I don't think this is better.  libxfs' init functions do not create or
> assign the libxfs_init.{data,log,rt}.name fields, they merely reuse
> whatever pointer the calling program set.  Only the caller knows where
> that pointed to memory came from (stack, optarg, dynamic allocation) so
> only the caller knows how to drop the pointer.

Exactly.

> The original patch is more appropriate IMO but seeing as we're about to
> return from main and terminate the process, why do we care?  And if we
> do, shouldn't mkfs also free the other getstr() strings attached to the
> cli struct?

We probably want that, as having a clean xfstests run with addrsan is
actually really nice to have, as without that the addrsan support is
only if limited use.

> And shouldn't the exit(1) paths do likewise?

Maybe.  Although it doesn't really matter all that much.