Re: [PATCH for-next v3] xfs: fix NOFS state corruption in btree split worker

[Carlos Maiolino <cem@kernel.org>]

On Sat, Oct 10, 2026 at 06:46:42PM +0800, Kefeng Wang wrote:
> 
> 
> On 10/6/2026 2:06 AM, Carlos Maiolino wrote:
> > On Mon, 21 Sep 2026 15:10:30 +0800, Kefeng Wang wrote:
> > > xfs_btree_split_worker() calls xfs_trans_set_context() and
> > > xfs_trans_clear_context() on the caller's transaction, overwriting
> > > tp->t_pflags with the worker's NOFS state. When the caller already has
> > > PF_MEMALLOC_NOFS set (e.g. xfs_end_ioend_write, xfs_dio_write_end_io),
> > > the corrupted tp->t_pflags causes xfs_trans_free() to erroneously clear
> > > the caller's NOFS protection.
> > > 
> > > [...]
> > 
> > Applied to for-next, thanks!
> 
> Thank，I checked linux-next's next-20261009, and there was a commit
> 23f91a51425e, but the code was incorrect during the conflict resolution.
> I don't know if this is the correct state for linux-next, just a reminder.

Linux-next appears to have removed all changes from this patch. I don't
know why it happened honestly, I'll need to dig into it later. IIRC
there was a conflict with -mm patches.

Patches staged for xfs are in xfs-linux/xfs-7.4-merge. Code there is
correct.
I always attempt a merge against Linus's tree before sending him the
patches and at the time if I see any conflict, I'll give him a heads up.

Thanks for letting me know though. I don't keep comparing xfs-linux
state against linux-next.

> 
> 
> > 
> > [1/1] xfs: fix NOFS state corruption in btree split worker
> >        commit: 23f91a51425ed3d4a5c42978fc25f1087611e4ba
> > 
> > Best regards,
> 
>