From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Zorro Lang <zlang@kernel.org>, fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Andrey Albershteyn <aalbersh@kernel.org>
Subject: Re: [PATCH] generic/805: mask unmount failures on cleanup
Date: Thu, 15 Oct 2026 07:54:26 -0700 [thread overview]
Message-ID: <atDpInBpIksOo_cj@infradead.org> (raw)
In-Reply-To: <20261015143649.GM2705364@frogsfrogsfrogs>
On Thu, Oct 15, 2026 at 07:36:49AM -0700, Darrick J. Wong wrote:
> The test vm boots off NFS to test XFS, so / and /mnt are NFS.
> SCRATCH_DEV is XFS, so when SCRATCH_MNT is mounted, /mnt/s will be XFS.
> After unmounting SCRATCH_MNT, /mnt/s will look like it's NFS, so that's
> why umount does what it does:
>
> # mkfs.xfs -f /dev/sda
> # mount /dev/sda /mnt/s
> # umount /mnt/s
> # umount /mnt/s
> umount.nfs: remote share not in 'host:dir' format
> umount.nfs: /mnt/s: not mounted
>
> (I'm not fstesting NFS, I left that to Chuck and Anna.)
Ah. The patch looks good then:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-10-15 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 3:32 [PATCH] generic/805: mask unmount failures on cleanup Darrick J. Wong
2026-10-15 5:59 ` Christoph Hellwig
2026-10-15 14:36 ` Darrick J. Wong
2026-10-15 14:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atDpInBpIksOo_cj@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox