Re: [PATCH v3] iomap: only follow dio alignment requirement if specified

[Christoph Hellwig <hch@infradead.org>]

On Thu, Oct 29, 2026 at 07:04:57AM +1030, Qu Wenruo wrote:
> 
> 
> 在 2026/10/29 01:56, Christoph Hellwig 写道:
> > Can you please write a normal commit log for this?  I.e. explain the
> > problem and the highlevel fix in short sentences.  No need for [] tags
> > or xfstests output.
> 
> I think this is really up to personal tastes.

To a minor point, yes.  But there's also plenty of fully objective
reasons against this style.  One is that is inconsistent with the rest of
the iomap commit message.  Please stick to the style of the surrounding
code, and that includes the commit message style.

The second is that this style is not good for bisecting or understanding
the code.  It takes 2 and half pages of scrolling before getting to any
useful information.  There is way to much information in here that
does not help understanding the change.

> I understand that too detailed commit message is slowing down the review,
> but if someone else in the future needs to re-check this commit, I guess
> they would prefer more details than less.

Quite to the contrary.