Re: [PATCH 03/25] xfs: always call xfs_update_stable_writes in xfs_ioctl_setattr_xflags

["Pankaj Raghav (Samsung)" <pankaj.raghav@linux.dev>]

On Wed, Nov 04, 2026 at 09:57:07AM +0100, Christoph Hellwig wrote:
> Currently xfs_update_stable_writes() is never called when the RT flag is
> flipped because xfs_ioctl_setattr_xflags() updates ip->i_diflags before
> comparing the rtflag variable to XFS_IS_REALTIME_INODE(ip), and thus
> the stable flag can be set incorretly when flipping the realtime bit
> on an existing file.
> 
> Fix this by unconditionally calling xfs_update_stable_writes for regular
> files.
> 
> Fixes: d528a6c1d4b6 ("xfs: data checksums require stable writes")

Shouldn't this patch be folded in to the stable writes patches?

> Reported-by: Wilfred Mallawa <wilfred.opensource@gmail.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/xfs/xfs_ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index f81b6e52ac40..36ba609a2593 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -595,7 +595,7 @@ xfs_ioctl_setattr_xflags(
>  	 * Make the stable writes flag match that of the device the inode
>  	 * resides on when flipping the RT flag.
>  	 */
> -	if (rtflag != XFS_IS_REALTIME_INODE(ip) && S_ISREG(VFS_I(ip)->i_mode))
> +	if (S_ISREG(VFS_I(ip)->i_mode))
>  		xfs_update_stable_writes(ip);
>  
>  	xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
> -- 
> 2.53.0
> 

-- 
Pankaj