From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.208 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794519503; b=iHXqGqtUoVOpG9dqL/sm4tCr5LxRzf71hd5NLdx4pwn3YTJcB7ULM6ZbFepvej/2nHtO mztHhlxHsABe4Lhtq4yZKXDNN4y2bUTE2yS+gdLqSsM/moxzBZbGqsGMYdwAyyWBEa4r2 pxIxbPMC2qk7zh23KomtC2t3OJYeoK938QwqnUG46cIDktIXRxB34gGdsQR0STU0B6xVZ +5Wlf0pWkLgpEWrSnr6lZsGTeVxLUctGNlCLIRNjIsg5McmDpniI2P+WWh+Pt3maV3TTT uXn8dwWRDdlZsNcBTF2LSJbz6aNS3T4MqJwdtUm/9YHwERKBqIJ5dTOQ4tgDKVl935Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794519503; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=X28tU+VHlLKxUHzEoE+kmXFHhe6QzoTUG/4AO0xtTjQ=; b=Dd6qrE9pwB4b4Hg0CAyukVtDw/RFwAuYxKMeTVmj0zT7ZIELlLuEIuRrx3rX3X1rHHoM cryamL+fcsNPgZVqa6/fYiHFrKVJjP/hcQY65f8zqFsZM1Lj/uaklUOWbjA0TyOiIGqim vKX9tvOvdF9CkCPvDHzGIbyxUa+OWrWJflrjO+B5T6oYwzfmKjECSb3wFjlpsbyF7avi0 i6zdkNciFxvp8ntvMfcII3/mmuu418o6jQDMlswohBg06JlSphY/7oeDm7aTSZgMqn2s9 AlhjuNgGmHrd13wsbViUtc/470hdbVvQq0xVQajV0MqDZS0HXy3rXj0i67Es7htqkiA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=FKO85Hco; arc=none smtp.remote-ip=95.215.58.208 Received: from mta1.migadu.com (out-208.mta1.migadu.com [95.215.58.208]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B79606A31C for ; Thu, 12 Nov 2026 21:38:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96B79606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=FKO85Hco X-Envelope-To: linux-xfs@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=wMqUnga3gDuBai4kY377b3ZGs9DrRI4VV/poGtMkEm4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794519500; v=1; x=1795124300; b=FKO85Hco90mmUSOELoiXdXNNpY+TfjcqWkGb18zfD3g73pbBt4en/0B+vrkuOB/JprTc03Ta NIfpqH4/kkD9qqB4jZ80YjQKatHUe0ZDrU9klvDF7aoHGma5ZWHMYbufA/zZ9y9rKMs47LJ+5yw 6CrtvfQutcZJV7ogzOrCTDEc= X-Envelope-To: linux-xfs@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 23f16d96141c72cc; Thu, 12 Nov 2026 21:38:20 +0000 X-Mizu-Trace-ID: 23f16d96141c72cc X-Migadu-Flow: FLOW_OUT Date: Thu, 12 Nov 2026 22:38:08 +0100 From: "Pankaj Raghav (Samsung)" To: Daejun Park Cc: Carlos Maiolino , linux-xfs@vger.kernel.org, Pankaj Raghav , John Garry , "Darrick J. Wong" , Christoph Hellwig , Dave Chinner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xfs: check the disk address for hardware atomic writes Message-ID: References: <20261112-xfs-hw-atomic-align-v2-1-c90394805e7b@samsung.com> X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261112-xfs-hw-atomic-align-v2-1-c90394805e7b@samsung.com> On Thu, Nov 12, 2026 at 09:41:56AM +0900, Daejun Park wrote: > xfs_bmap_hw_atomic_write_possible() checks the alignment of the encoded > br_startblock, not of the disk address. This was harmless while atomic > writes were capped at the greatest power-of-two factor of the group > size. > > Commit ec8f62cc109a ("xfs: don't limit software atomic writes by the > group alignment") lifted that cap. The block layer can now fail a > misaligned write with -EINVAL, and XFS does not fall back to COW. > Unaligned AGs, such as those made by mkfs.xfs before 6.16, and rtgroups > made by any version can hit this. > > Check the disk address instead. > > Fixes: ec8f62cc109a ("xfs: don't limit software atomic writes by the group alignment") > Signed-off-by: Daejun Park Looks good, Reviewed-by: Pankaj Raghav (Samsung) -- Pankaj