From: Allison Henderson <allison.henderson@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: make xfs_file_remap_range() static
Date: Thu, 15 Nov 2018 12:21:19 -0700 [thread overview]
Message-ID: <b2537174-6c2e-b7a4-9ad8-93bbc9001c53@oracle.com> (raw)
In-Reply-To: <20181115011217.104363-1-ebiggers@kernel.org>
On 11/14/18 6:12 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
> static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 53c9ab8fb777f..e47425071e654 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -920,7 +920,7 @@ xfs_file_fallocate(
> }
>
>
> -loff_t
> +STATIC loff_t
> xfs_file_remap_range(
> struct file *file_in,
> loff_t pos_in,
>
Looks ok to me. You can add my review:
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Thanks!
Allison
prev parent reply other threads:[~2018-11-16 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 1:12 [PATCH] xfs: make xfs_file_remap_range() static Eric Biggers
2018-11-15 5:58 ` Darrick J. Wong
2018-11-15 19:21 ` Allison Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2537174-6c2e-b7a4-9ad8-93bbc9001c53@oracle.com \
--to=allison.henderson@oracle.com \
--cc=ebiggers@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).