From: Allison Henderson <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 03/12] fsx: shut up compiler warnings
Date: Sat, 24 Nov 2018 11:23:07 -0700 [thread overview]
Message-ID: <b4c306aa-95a3-34d8-cf1a-ceec9cbf8fa4@oracle.com> (raw)
In-Reply-To: <154290952722.1218.5031880474187869562.stgit@magnolia>
Looks good:
Reviewed-By: Allison Henderson <allison.henderson@oracle.com>
Allison
On 11/22/18 10:58 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Fix unused variables and potential filename overflows in fsx.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> ltp/fsx.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index b0157ba3..5601c70c 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -121,7 +121,7 @@ char *bname; /* basename of our test file */
> char *logdev; /* -i flag */
> char *logid; /* -j flag */
> char dname[1024]; /* -P flag */
> -char goodfile[1024];
> +char goodfile[PATH_MAX];
> int dirpath = 0; /* -P flag */
> int fd; /* fd for our test file */
>
> @@ -185,7 +185,7 @@ const char *replayops = NULL;
> const char *recordops = NULL;
> FILE * fsxlogf = NULL;
> FILE * replayopsf = NULL;
> -char opsfile[1024];
> +char opsfile[PATH_MAX];
> int badoff = -1;
> int closeopen = 0;
>
> @@ -541,13 +541,13 @@ mark_log(void)
> void
> dump_fsync_buffer(void)
> {
> - char fname_buffer[1024];
> + char fname_buffer[PATH_MAX];
> int good_fd;
>
> if (!good_buf)
> return;
>
> - snprintf(fname_buffer, 1024, "%s%s.mark%d", dname,
> + snprintf(fname_buffer, sizeof(fname_buffer), "%s%s.mark%d", dname,
> bname, mark_nr);
> good_fd = open(fname_buffer, O_WRONLY|O_CREAT|O_TRUNC, 0666);
> if (good_fd < 0) {
> @@ -1865,7 +1865,7 @@ main(int argc, char **argv)
> {
> int i, style, ch;
> char *endp, *tmp;
> - char logfile[1024];
> + char logfile[PATH_MAX];
> struct stat statbuf;
> int o_flags = O_RDWR|O_CREAT|O_TRUNC;
>
>
next prev parent reply other threads:[~2018-11-25 5:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 17:58 [PATCH v3 00/12] xfstests: add copy/dedupe/clone to fsx/fsstress Darrick J. Wong
2018-11-22 17:58 ` [PATCH 01/12] fsstress: fix compiler warnings Darrick J. Wong
2018-11-24 18:22 ` Allison Henderson
2018-11-22 17:58 ` [PATCH 02/12] fsstress: check system call return values Darrick J. Wong
2018-11-24 18:22 ` Allison Henderson
2018-11-22 17:58 ` [PATCH 03/12] fsx: shut up compiler warnings Darrick J. Wong
2018-11-24 18:23 ` Allison Henderson [this message]
2018-11-22 17:58 ` [PATCH 04/12] fsx: always check buffer after each operation Darrick J. Wong
2018-11-24 18:24 ` Allison Henderson
2018-11-22 17:58 ` [PATCH 05/12] fsx: use an enum to define the operation commands Darrick J. Wong
2018-11-24 18:23 ` Allison Henderson
2018-11-22 17:59 ` [PATCH 06/12] fsx: add five-argument logging function Darrick J. Wong
2018-11-24 18:23 ` Allison Henderson
2018-11-22 17:59 ` [PATCH 07/12] fsx: add FICLONERANGE support Darrick J. Wong
2018-11-22 17:59 ` [PATCH 08/12] fsx: add FIDEDUPERANGE support Darrick J. Wong
2018-11-22 17:59 ` [PATCH 09/12] fsstress: add copy_file_range support Darrick J. Wong
2018-11-22 17:59 ` [PATCH 10/12] fsx: " Darrick J. Wong
2018-11-22 17:59 ` [PATCH 11/12] common/dump: disable copyrange Darrick J. Wong
2018-11-22 17:59 ` [PATCH 12/12] generic: long fsx soak tests Darrick J. Wong
2018-11-25 16:27 ` Eryu Guan
2018-11-26 20:50 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-12-07 6:23 [PATCH v4 00/12] xfstests: add copy/dedupe/clone to fsx/fsstress Darrick J. Wong
2018-12-07 6:23 ` [PATCH 03/12] fsx: shut up compiler warnings Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c306aa-95a3-34d8-cf1a-ceec9cbf8fa4@oracle.com \
--to=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).