public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: djwong@kernel.org, cem@kernel.org, linux-xfs@vger.kernel.org,
	ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v1 1/4] xfs: Fix xfs_last_rt_bmblock()
Date: Wed, 18 Feb 2026 13:17:24 +0530	[thread overview]
Message-ID: <b4e97ebc-fa34-4bfa-8331-6a149f65b301@gmail.com> (raw)
In-Reply-To: <aZVTwrR4ORzYALSy@infradead.org>


On 2/18/26 11:23, Christoph Hellwig wrote:
> On Thu, Feb 12, 2026 at 07:31:44PM +0530, Nirjhar Roy (IBM) wrote:
>> Reproduce:
>> $ mkfs.xfs -m metadir=0 -r rtdev=/dev/loop1 /dev/loop0 \
>> 	-r rgsize=32768b,size=32769b -f
>> $ mount -o rtdev=/dev/loop1 /dev/loop0 /mnt/scratch
>> $ xfs_growfs -R $(( 32769 + 1 )) /mnt/scratch
>> $ xfs_info /mnt/scratch | grep rtextents
>> $ # We can see that rtextents hasn't changed
> Please wire this up in xfstests.

Yes, I have prepared a bunch of XFS realtime grow and shrink tests as a 
part of XFS realtime shrinkfs work. That will cover this fix (and a 
couple of other fixes that I posted earlier). I will send them shortly 
in a few days.

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thank you.

--NR

-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore


  reply	other threads:[~2026-02-18  7:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 14:01 [PATCH v1 0/4] xfs: Misc changes to XFS realtime Nirjhar Roy (IBM)
2026-02-12 14:01 ` [PATCH v1 1/4] xfs: Fix xfs_last_rt_bmblock() Nirjhar Roy (IBM)
2026-02-18  5:53   ` Christoph Hellwig
2026-02-18  7:47     ` Nirjhar Roy (IBM) [this message]
2026-02-12 14:01 ` [PATCH v1 2/4] xfs: Update sb_frextents when lazy count is set Nirjhar Roy (IBM)
2026-02-18  5:54   ` Christoph Hellwig
2026-02-18  8:49     ` Nirjhar Roy (IBM)
2026-02-19  6:38       ` Christoph Hellwig
2026-02-19  6:46         ` Nirjhar Roy (IBM)
2026-02-19  6:51           ` Christoph Hellwig
2026-02-19  7:05             ` Nirjhar Roy (IBM)
2026-02-19  7:07               ` Christoph Hellwig
2026-02-19  7:09                 ` Nirjhar Roy (IBM)
2026-02-12 14:01 ` [PATCH v1 3/4] xfs: Update lazy counters in xfs_growfs_rt_bmblock() Nirjhar Roy (IBM)
2026-02-18  5:55   ` Christoph Hellwig
2026-02-18  7:48     ` Nirjhar Roy (IBM)
2026-02-12 14:01 ` [PATCH v1 4/4] xfs: Add some comments in some macros Nirjhar Roy (IBM)
2026-02-18  5:56   ` Christoph Hellwig
2026-02-18  7:50     ` Nirjhar Roy (IBM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4e97ebc-fa34-4bfa-8331-6a149f65b301@gmail.com \
    --to=nirjhar.roy.lists@gmail.com \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox