linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH 0/2 V3] xfs_repair: rework inode clearing and free inode validation
Date: Mon, 23 Jul 2018 19:27:07 -0700	[thread overview]
Message-ID: <b6f745ab-3016-9a95-3085-8584f7200b64@redhat.com> (raw)

Warn the user if any free inodes contain errors, and set exit code
in the process.  Do this by running the existing dinode verifier and
clearing / warning if it fails.

2nd patch separates out the inode validation from the clearing function

There is a functional change here which I'm on the fence about; free
inodes are now only cleared if they won't pass the dinode verifier,
which is the only thing the kernel would squawk about.  But that's
a subset of the clear_inode checks.

The old clear_dinode function checked a lot of things that the
verifier simply doesn't care about, but I think it's ok for
those tests to go away; if the kernel does care about, say, extent
count on a free inode, the verifier should test it.

             reply	other threads:[~2018-07-24  3:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  2:27 Eric Sandeen [this message]
2018-07-24  2:34 ` [PATCH 1/2 V3] xfs_repair: notify user if free inodes contain errors Eric Sandeen
2018-07-24  4:35   ` Eric Sandeen
2018-07-24 21:43     ` Eric Sandeen
2018-07-25  4:25   ` Carlos Maiolino
2018-07-25 16:31   ` Darrick J. Wong
2018-07-24  2:50 ` [PATCH 2/2 V3] xfs_repair: clear_dinode should simply clear, not check contents Eric Sandeen
2018-07-25  4:48   ` Carlos Maiolino
2018-07-25 16:32   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6f745ab-3016-9a95-3085-8584f7200b64@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).