From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF711F16B; Tue, 21 Oct 2025 03:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761016639; cv=none; b=QvoDTLSRLsu8kA7nhlEyNBawSYj9E7GR6cvh66zG8qJLyylauEChY5ynmIuBSih5w3h+8j/zqfI5L1qGm4krJJTYVd7ZmAYx2LPDzHHusm0al7ESOHnpCwok+BvvKHIfEWbqHVN8TUJrIpNwmkEgmJo7HBchjWV+di+8WLhO880= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761016639; c=relaxed/simple; bh=Kh1SyStXJPG/UN/20xIpd9r7yNVZN6g5tCu2/tEqBys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lNvwLhqLJvMZ0bdt3mTt9cCfe3HXf/d5bABqKQysikBwOpHmQEm2E4jbC2L/yUf776eyA2X87RHbV3Ofi6Vdy1kll0+QEZn8GIlNmz5g7AdDY0doCF7NLVCZcuTWRjVyTU6nSzJ7I/W94JCprD7Ijl1zawwzXKcEgjXltKnIG1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.com; spf=pass smtp.mailfrom=gmx.com; dkim=pass (2048-bit key) header.d=gmx.com header.i=quwenruo.btrfs@gmx.com header.b=opuuB7Hl; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.com header.i=quwenruo.btrfs@gmx.com header.b="opuuB7Hl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com; s=s31663417; t=1761016630; x=1761621430; i=quwenruo.btrfs@gmx.com; bh=Kh1SyStXJPG/UN/20xIpd9r7yNVZN6g5tCu2/tEqBys=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=opuuB7HlyLZsToRbyaflDxs54OlYAVIOUaSCSX+j67lupdVPo0HfCVto5Rc1LUXc 8e6isj+Mh2JpH9aZE/VfNBcyqs4MXhu6DRssk5ML2kfoT6SSgImySvaYA44ed78Aq uS8dNCUnVdlRTQUUzDGWTceP/MSjm3zdION1umqxkRxfyUwijRaRfzpab7fB/hntT A48dSkFL7W9ZTgBgJ6keYa927TNPjxX2WsqVRzRnzmIyjuzTV1yMo2tCtjed0zb9G a16XDgEbhVb6MyBii3m26lGxX/DtdqBs0eUJi0/oXn8W9+SRxyun2+2ikVwQlnkY4 ewXVOL94gYcGvrkmbQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [172.16.0.229] ([159.196.52.54]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MHXBp-1uy4IO2wUL-00EP9l; Tue, 21 Oct 2025 05:17:10 +0200 Message-ID: Date: Tue, 21 Oct 2025 13:47:03 +1030 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: O_DIRECT vs BLK_FEAT_STABLE_WRITES, was Re: [PATCH] btrfs: never trust the bio from direct IO To: Christoph Hellwig , Qu Wenruo Cc: linux-btrfs@vger.kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, martin.petersen@oracle.com, jack@suse.com References: Content-Language: en-US From: Qu Wenruo Autocrypt: addr=quwenruo.btrfs@gmx.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNIlF1IFdlbnJ1byA8cXV3ZW5ydW8uYnRyZnNAZ214LmNvbT7CwJQEEwEIAD4CGwMFCwkI BwIGFQgJCgsCBBYCAwECHgECF4AWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCZxF1YAUJEP5a sQAKCRDCPZHzoSX+qF+mB/9gXu9C3BV0omDZBDWevJHxpWpOwQ8DxZEbk9b9LcrQlWdhFhyn xi+l5lRziV9ZGyYXp7N35a9t7GQJndMCFUWYoEa+1NCuxDs6bslfrCaGEGG/+wd6oIPb85xo naxnQ+SQtYLUFbU77WkUPaaIU8hH2BAfn9ZSDX9lIxheQE8ZYGGmo4wYpnN7/hSXALD7+oun tZljjGNT1o+/B8WVZtw/YZuCuHgZeaFdhcV2jsz7+iGb+LsqzHuznrXqbyUQgQT9kn8ZYFNW 7tf+LNxXuwedzRag4fxtR+5GVvJ41Oh/eygp8VqiMAtnFYaSlb9sjia1Mh+m+OBFeuXjgGlG VvQFzsBNBFnVga8BCACqU+th4Esy/c8BnvliFAjAfpzhI1wH76FD1MJPmAhA3DnX5JDORcga CbPEwhLj1xlwTgpeT+QfDmGJ5B5BlrrQFZVE1fChEjiJvyiSAO4yQPkrPVYTI7Xj34FnscPj /IrRUUka68MlHxPtFnAHr25VIuOS41lmYKYNwPNLRz9Ik6DmeTG3WJO2BQRNvXA0pXrJH1fN GSsRb+pKEKHKtL1803x71zQxCwLh+zLP1iXHVM5j8gX9zqupigQR/Cel2XPS44zWcDW8r7B0 q1eW4Jrv0x19p4P923voqn+joIAostyNTUjCeSrUdKth9jcdlam9X2DziA/DHDFfS5eq4fEv ABEBAAHCwHwEGAEIACYCGwwWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCZxF1gQUJEP5a0gAK CRDCPZHzoSX+qHGpB/kB8A7M7KGL5qzat+jBRoLwB0Y3Zax0QWuANVdZM3eJDlKJKJ4HKzjo B2Pcn4JXL2apSan2uJftaMbNQbwotvabLXkE7cPpnppnBq7iovmBw++/d8zQjLQLWInQ5kNq Vmi36kmq8o5c0f97QVjMryHlmSlEZ2Wwc1kURAe4lsRG2dNeAd4CAqmTw0cMIrR6R/Dpt3ma +8oGXJOmwWuDFKNV4G2XLKcghqrtcRf2zAGNogg3KulCykHHripG3kPKsb7fYVcSQtlt5R6v HZStaZBzw4PcDiaAF3pPDBd+0fIKS6BlpeNRSFG94RYrt84Qw77JWDOAZsyNfEIEE0J6LSR/ In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:heh+exyaLZgTrjGd1PWKLbOpy5V579t59E47W4iGAQrBv/QN7lM b8+63YHNXJNUp0KAE1vp20tRJhPkVXAOL/yucj6sD5NzyKLWeCgTK/bggsCBL/KBQe8d5Yx 6dx5s6pRPJw+Sa9ltQHA8faBlrftyNx4A8GMsToGJamT7vtv6ZwJlDu32zFf27gQHQSXQia VELLANNZ6ColOY5cg1zGg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SsvwGXYMYFs=;1DBgOk85iNX1tFewJeknkLq/ea1 FIl/m4ub9ZHlkv/qNGbO9vPFAmhkUR+07nntrvtW8gXnbCSzQjZMipPaxEITZjXuzvrV21418 UUIiPOnvLnpsZDCwEZBBKEMFQ+7uzmE+jqtM52jUm5lYZuoMM67l27ynXwf3/b/y3pOc0f815 hg7xXXT3LvvxL7dbI2uMhRqzDkyRIXNVf34SGdPPxvDeJPY8iAQv45E6HuvaHPqalzwzWmjcc JSOps6IHPxumxsvtCNmN2lOd4oqa14Uev5VcQGEvovV84Hx7OAlciO3JqqYMlN+fS66t7bCf0 nyiaSUz+d0fJZhXA1s2NfcDixg3vc1U9nXLNKmdY94mW2TFFykL4UJrQ5RDzoljBqCDpPa42e Ywt6iYSj0H5jcaQ2wxH+3zlpseYSwL/Yb2FVjBwFigQ2o8/9mJ6pr569p5JqYAFuQ89z66HTH 1uQY8JuBK289tfHJCsNGhIX6uKT9tJtYg45lHhufJXFk3LNE79vBIRZkkN8JqnMkxp0agN5O5 AnIZ0n513EFaPf1rsxQb+O82UjeGVbQPkt0IRVcHj49howfPMQxKu+w1XXqklBe/7JRSTU0+f zEGOowiXQvU/sN3apIK97mMcj7CTbK5lxkA9hXRKlRC5Y9tYAE6FMWBh3X+BmtbvOeOcQn/n0 0rYzTiU3FQBPSCjJMDT7XRemxZv5YFTRgxghpME3RD65v7juvMal1H9MDRCKbfTqh920BQZDZ w/CkiC3MUyb578qeOny7CuCFccXAQoINq5WohQeE/oZm6EMoiFVBTfk7AVYaBMIFBWYur0wHB ik1puKCv5X+UVpOrddDCCOHP1qZCbbe/zAK5YJ8BeyB7/BO046fnQu4pgAzreahGHYeCs2qql T7tZWc/JgjC6e8S6Y//eZgykK6g5NTeNsSBZyFaoFm5NTDHXNTNjN5lmtgd54BY6ayJbN7/YO jBa3Xnlu8JIGu0/E200G4SZ+Io6dnQ0oMw8/BgGcvEHzONR6YxLPxFLslBOWXV99DabErsDIP L7UT5aor/kY0PXlV9Dp75vLl3hanNzPMhOnWqrQEyzLHumtPbHaE/Qx0teGJB1dwWOLXIjXT6 U7OlxvFYfHu/MhCMeEpiMEOCRQGOYdphUHbBq1fesPRdllLGOL8A6KHWoZoawYyJDos4Yl9ga 6yPnsu7MyTF3Q3VU2ir4pI3c7K62yIXMpHB5nt2POa87IMS13vSuYM9B31WZ7+vPwZ7qzqRK5 QqcFVPpGsVtalRfTzTPAPEfySwxQXdIaXMG9JcUiKHl7R5xZGpVqyveI9/zXQgQpIQbBpxbJg zap98VfZScXtGKGbVekouhhe6XwCtgtuDqvg0oo28d/I0or7181KXcbkI/MNj8df+UEOG/MM1 1hsT6adNkhhBu7EP++0c3Qn4Rw6EaLXzdobxpfBTq8nlO8UqtcN52kAF3CwEVBnno8vuv2XiD Uwrs4v6IqCYSbno4KR6hm68alin+SPQAxPGBxls0AO8mK10CB1U0aQLXbSkEzDQu3IaqHy7kT eqqIjvwgyhif9M3ddu/P5ziljZCTBbhboyn6dpjVfo0cr9/dUVLrLugEmfi81a+qpsO4nmLlw xwLq0JRrnfXz4evRXNMcC4OsIZTkmdOE76R5EVd3h6j/XlHcktWcnyKtEByq/2xOk8ejJ8BVF raMa1zd6l/WDsRS8NcBxNFVLqMAG2KGTekAXfmjCgrRf4sPUx+Ka7xeHWlC4fYWv8/2vtZepp Rw5m7EAM0dQbGZ6JXgaJGaWsXIF3r0b8XSSRDnjRpnaHZVXeKx7+9cfGH6Fy3ARFjucRQxrZD TrjE01gnTKwy9bSMtZV8QizVZUD33tkt+0uoSozJgA8NkN8dGMHX39xwc8lQ+hkArkSFMGxyh lYJ2qhUh6wmHh5Fp87ScIbFx7f9iYitbWxPq5BZ4f03kesTLgO6Pdryiuj0dkC+UQ/jMfJjt2 L0CmeDVwdf02L13IxfTJZpGUGo3S5l5omQM3Vr8pIqP8AItiw1iVvP7RmcqaTAc0Ok3kzEXwi RUJAW+B0M56fse6evJ/uv3peXYJYKawJll8auR/LYVH1B+KrToEUC1xn6xY4oaCQiyVUl1eVk va62Zr2ykEhE81RzY1rPKJCVNlo/G6Y0mLJNBfeZkrcxCuXi/3IPSeWEUOgG1ytNwrKHW0uxz BJSxHe70dQc1FS2awle+YNcndTXjPoGOGOHuVR9yMvZOp0MoV6aPQN9G8TsqKDesXH8qUFx6o RGxsILAunfzx4gjCXqWiqTJWi87GPl9l6R/SG9Zly58aiHRS1GqG3T3XCWg/73wQ2fE1STbQJ EdwpPs38JM09XrKbe1O3exFZM169FLYlfsRHMHtS1QF9viFr8Y05drTga7CPrOk7u3ipKAJM/ dXwMzv+LGxZ2JBnI8ddY4qDPx59qHz5WyyAqZCcI1K+q8B9qp05YjZlFd70ol+4qvg167QH0s SmnwvrYaDqH4tfbKs2lXOuVNhZtymus1X/zLuIXS4atPCWp/1mEL1rn1rIJX0UFd8itz1QEoA okmKAYXLzIfaKKUyIrKJ8rzXF6wT9MFISW39aS5RpximVisS1mungFXDksIEQiAdiLkDhsUT1 RPWyfsnPgqaqS0wuYjE3FgsbBtebw3le6l73L8WhqiVnpPhOGCDy0K9YvCg8/XlQEkDfGZ9+6 W4JutW78XOzQYikWzqvi9P0mRK2iEEeJwtecBYNlBNa1/CBEpq2CqPgrncx9B5gPdbLz7KiH0 vv3KKs7aSTvt3c8HmWq8jCugd2TWoDRyilVFom06Gw5uO05H7lSyORJ9T9HKuToH7VJxZCsu/ gPnlCVmFqC/aCK2SDtASymEmFRB+vjkzWPs0U4qeJf9kMKlj11gceAfF36izkh9Cugrbxs328 im1J8mqYVKkNZbhgbeZAFbYG03FXZ+jeyOzge1yiKDV+gd+xGXthzdYuHhAbcVuFLRPbfjO9m Sx1TnagNCiUR8CzpF2PAKT4PR8GqqVOFcpP1U4jM1ExuMxWQIeDD+TD9736Y7gnZdebiKW45/ MLqnRq8xVYi32EK0XJJR3aZRiBkFPvG3bWgTY3VO8PVk+iE0JroU7Uk4rYy8HK2UG/wETjhvo x/PU3kDoYJ2aCBxlqMitMxJtLXLiBU4KIL/7fsjKGG//cwSNsVWeETEFDPqi7ADplRNF58xAL R58CzuTykPswES4QMWBa8f8aaIAnwwK+lcXjOezTbZYd38OxfjGA0rNdPHOFDA6/Law04eQWh bWMFWzqNC+Zf7bTQNlDM0pDTC+y++JADVYGHgWENGiIsNbkR4dLZo9pwk/adPYP9D0DNDYHxK 9ibVXH38ZReYaoq7ybpKe2UGsGDAb0J8bQ9BDroMGJtEoehcUZ2UT7X/NpRKvzYk1kLyDz6iE UiZKeshBeBFke9VrmzS3QuIDXoVnQOemwRc6lcVUnItx0VleV4iyI6CAqKyUDqzW2B6G2L2B5 UtvtXAQaUwAobc8FU4TVNAWVc2j2yZqXv2LRvo8ihRuk/Pa0IAg1yHKk25IdmHqG/zVq2j0fz +RTt9ROOt3e6+iNtHiIJMShib5pt2z2pOfZQzhlDAOy00mQNHxY1+yu9b5Zp1Cn03z9r0JN73 lVEWmM9EhGlkNCs6ob5Ut/GF6lQYXN8sWaFBNHHfcH3KMebT8W7wsg3TjDUkv2uY+rsNV6UzB vuQOP7k9tbj/LRUGGK3mYlvFdoW24hBcG4fbDk2dZpah/EOPMlPpFLVyhzlIKH7mqo7KAlFKx cza9/ENhKrGN1+haWYbNk9KAxtlVs4+hzBa9iXWNGl64ZV/yGYAdvjxr+G0qhu3wBK6ofhPDY 1BwGSHT0Rz8HoWNhyHbbvXg096ktpI7FGc4ViNsEFNs/znWWcZOLpPFmBpzAcXEe3Tx9GbY7E Tf61DkrZ80+umbqCBje3QHjbbgzUlUCK9uQbXeClxhoXnBTh4b/EJYbJB4TxsTTSuR37fWYFb 4QRWYYFA1II3HLldNFN6vVZsGuEM27XYQESxGB32ysbKiSNK4S8aoYNtsOo95CfE35cps8XiR 5HKMwAO5HOa3hzekVZClgvOUR9y/TTaOzFz+My6yJnZkM2a4c60c5PHC7v2rJbrC5J9ZVlh6Q DD55deFZ60O6jzuNoU/SF7w3T+5rYl5f1y/XxHBJJUQHVQ6udMoyTQTTFDBjiXaGd4s9EiUnn bixZV4LjK+AXkHI7K9dYDmwEI2Cs8YePW1ZF+CieT8UysV9RT4SwHjXPbvCQcSzGeJG8DYi6y 3+CH4OICiMYjLQs6E3O7EnmPDhUAv4PDIz4G2SXn2Sq2pAxDgqEzU01IiV2lslR6rwoUWRSpB jT6n6qEIIuh+UovG5pynr48S7CW4VILxDoAlVP1DHW00nUd+LLKA0Bnm53iJw/9uJKX3WOdrT wmmLZ4BUqMUemWUBVK2QYiEKDycN5WemAXHhu4hq6XClEXWDb/A6LSE7luFJrRWqpRGaqIqSC HwJXLs9GWqc5vLkGxP2taihvyaqSqY/YoOQdWbBB6M5HDP/B6b+wDRDEQPBPLqqYcQ/Otg3Ol 7HvX2z2BW8hFZI/cVVdaJHq7k5gCYUX/trG1Te1PCYTEG5LVzdo2I4uv5GEu5mW9QKxN3eJO7 jui9elOdrdoVp+/VVWYxE1HG9aJFn93WlQxaHNjf+k4R/M/XCnR1AjljRwSPfhTsj5aAgSTtS /UWU9oF/pox3tt2RrxaHEtZbrrodWMe3ehWCV6WfAfG3QvbY76bzKQ6e4vd9ah6Jmw5xmqh1X l9WKWRRZCGkvMkKM+RUCP4LTwdsVJGlZSHY4TafQLuKatYtv35W/LKyAYwm+lJH/54EArFo8i QNXgfYyUd8zYUAwFaO5cY5h5tpAzNo65QN7AIX7FrXCMVx3k88kBOOU8BkY/mNpxS+TxUG1Zp XuaJGFoHDtB8tHfMWajDBIpR34Iieq/VN+UJB5JRdC/kkTe53I+SVoUSMM//0iBNkh8F3tTvA zsGMYOUA7iojyLi3URxBIOnTEXkvy70Q+VYOEwiZzI2UQnep+IeRBGQPGW+30iEy3OdwJBqiR d8SfwT+Xcj3JR7gmyZ0pzJhWbE= =E5=9C=A8 2025/10/20 20:30, Christoph Hellwig =E5=86=99=E9=81=93:> >> But still, such performance drop can be very obvious, and performance >> oriented users (who are very happy running various benchmark tools) are >> going to notice or even complain. >=20 > I've unfortunately seen much bigger performance drops with direct I/O an= d > PI on fast SSDs, but we still should be safe by default. Off-topic a little, mind to share the performance drop with PI enabled=20 on XFS? With this patch I'm able to enable direct IO for inodes with checksums. I thought it would easily improve the performance, but the truth is,=20 it's not that different from buffered IO fall back. It's still the old 200MiB/s (vs ~2GiB/s nodatasum), no matter falling=20 back to buffered IO or not (and extra traces indeed shows it's really=20 going direct IO path). So I start wondering if it's the checksum itself causing the miserable=20 performance numbers. Thanks, Qu