From: Milan Broz <gmazyland@gmail.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>, dm-devel@redhat.com
Cc: Chris Murphy <lists@colorremedies.com>,
xfs list <linux-xfs@vger.kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: Testing dm-integrity (WAS: Re: Support for data CRC)
Date: Sun, 10 Sep 2017 22:06:13 +0200 [thread overview]
Message-ID: <bb924fb0-ba74-1f14-d1ce-ea567c641c54@gmail.com> (raw)
In-Reply-To: <20170910194350.v5fzbgrzihpjg2pv@breakpoint.cc>
On 09/10/2017 09:43 PM, Sebastian Andrzej Siewior wrote:
> On 2017-08-22 16:37:07 [-0600], Chris Murphy wrote:
>> Documentation says either crc or hash is possible, including crc32.
>> https://www.kernel.org/doc/Documentation/device-mapper/dm-integrity.txt
>>> My idea was that if the "normal" path is faulty (and noticed by the crc
>>> check) it (xfs or the dm layer) would try to read the data via an
>>> alternative path if possible (say on RAID1/5/6).
>>
>> Yes you have to build each layer you want separately with this method.
>
> So I tried this:
>
> dmsetup create test-raid1 --table '0 4194304 raid raid1 3 0 region_size 1024 2 - /dev/vdc - /dev/vdd'
>
> # creating the target (size 1)
> provided_data_sectors=1
> table="0 $provided_data_sectors integrity /dev/mapper/test-raid1 4096 - D 1 internal_hash:crc32c"
> dmsetup create dm-int --table "$table"
> dmsetup remove /dev/mapper/dm-int
>
> # hexdumped. is there a tool for that?
There is integritysetup tool (part of cryptsetup package) that automates format and mount of dm-integrity devices.
For now in devel git, I expect we will do some release package this month.
(So no need to use dmsetup here.)
...
> at some point I expected dm-integrity to check the other disk in RAID.
The dm-integrity has no connection to RAID, it will just return EILSEQ (instead of EIO error)
to inform that the error is an data integrity error, not a media (or other) IO error.
> Isn't this possible or is my setup wrong at some point? If it is not
> possible, could it be made possible?
It is up to RAID driver to handle integrity error properly (the same should happen
for hardware DIF integrity error I guess - you can try to simulate it with scsi_debug).
Milan
next prev parent reply other threads:[~2017-09-10 20:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 19:04 Support for data CRC Sebastian Andrzej Siewior
2017-08-21 19:52 ` Chris Murphy
2017-08-22 11:10 ` Sebastian Andrzej Siewior
2017-08-22 22:37 ` Chris Murphy
2017-09-10 19:43 ` Testing dm-integrity (WAS: Re: Support for data CRC) Sebastian Andrzej Siewior
2017-09-10 20:06 ` Milan Broz [this message]
2017-09-11 6:38 ` Sebastian Andrzej Siewior
2017-09-11 23:44 ` Mikulas Patocka
2017-08-21 23:02 ` Support for data CRC Dave Chinner
2017-08-22 5:51 ` Christoph Hellwig
2017-08-22 11:13 ` Sebastian Andrzej Siewior
2017-08-23 6:19 ` Christoph Hellwig
2017-09-10 19:50 ` Sebastian Andrzej Siewior
2017-09-11 6:37 ` Christoph Hellwig
2017-09-11 6:52 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb924fb0-ba74-1f14-d1ce-ea567c641c54@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-devel@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=mpatocka@redhat.com \
--cc=sebastian@breakpoint.cc \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox