From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.wl.linuxfoundation.org ([198.145.29.98]:55752 "EHLO mail.wl.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbfF3Nwp (ORCPT ); Sun, 30 Jun 2019 09:52:45 -0400 Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 236CA28733 for ; Sun, 30 Jun 2019 13:52:44 +0000 (UTC) From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 203947] [xfstests generic/475]: general protection fault: 0000 [#1] RIP: 0010:xfs_setfilesize_ioend+0xb1/0x220 [xfs] Date: Sun, 30 Jun 2019 13:52:43 +0000 Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: linux-xfs@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=203947 --- Comment #10 from Zorro Lang (zlang@redhat.com) --- (In reply to Darrick J. Wong from comment #9) > Zorro, > > If you get a chance, can you try this debugging patch, please? Sure, I'll give it a try. With this bug together ... they both triggered by g/475. You really write a nice case :) Both these two bugs are too hard to reproduce, so I only can try my best to test it, but I can't 100% verify they're fixed even if all test pass, I'll try to approach 99% :-P BTW, if this's a separate bug, I'd like to report a new bug to track it, to avoid confusion. Thanks, Zorro > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > index baf0b72c0a37..1bf408255349 100644 > --- a/fs/xfs/libxfs/xfs_bmap.c > +++ b/fs/xfs/libxfs/xfs_bmap.c > @@ -3846,6 +3846,12 @@ xfs_bmapi_read( > return 0; > } > > + if (!ifp) { > + xfs_err(mp, "NULL FORK, inode x%llx fork %d??", > + ip->i_ino, whichfork); > + return -EFSCORRUPTED; > + } > + > if (!(ifp->if_flags & XFS_IFEXTENTS)) { > error = xfs_iread_extents(NULL, ip, whichfork); > if (error) -- You are receiving this mail because: You are watching the assignee of the bug.