public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-xfs@vger.kernel.org
Subject: [Bug 204223] [fstests generic/388 on xfs]: 4.19.58 xfs_nocrc / xfs_reflink null pointer dereference at xfs_trans_brelse+0x21
Date: Sat, 20 Jul 2019 22:49:38 +0000	[thread overview]
Message-ID: <bug-204223-201763-ZOtqggK0xm@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-204223-201763@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=204223

--- Comment #8 from Luis Chamberlain (mcgrof@kernel.org) ---
These commits fix this crash:

xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h
xfs: Add helper function xfs_attr_try_sf_addname
xfs: Add attibute set and helper functions
xfs: Add attibute remove and helper functions
xfs: always rejoin held resources during defer roll

I've left generic/388 running over time and it ran up to 247 times
successfully, and failed but at least without a crash in the end.

In particular the last commit has has some fixes to correct bhold callers to
release held buffers correctly merged into the patch, which IMHO should have
been split up into a separate patch.

Trying to extract the exact minor fix is difficult due to the amount of churn
from the prior patches. We'll have to try to do that work somehow or just
consider merging all of these.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.

      parent reply	other threads:[~2019-07-20 22:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 19:03 [Bug 204223] New: [xfstests generic/388]: XFS: Assertion failed: ip->i_d.di_format != XFS_DINODE_FMT_BTREE || ip->i_d.di_nextents > XFS_IFORK_MAXEXT(ip, XFS_DATA_FORK), file: fs/xfs/xfs_inode.c, line: 3646 bugzilla-daemon
2019-07-18 19:08 ` [Bug 204223] [xfstests generic/388]: 4.19.58 xfs_nocrc XFS: null pointer dereference at xfs_trans_brelse+0x21 bugzilla-daemon
2019-07-18 19:32 ` [Bug 204223] [fstests generic/388 on xfs]: 4.19.58 xfs_nocrc / xfs_reflink " bugzilla-daemon
2019-07-18 20:21 ` bugzilla-daemon
2019-07-18 20:22 ` bugzilla-daemon
2019-07-19  3:26 ` bugzilla-daemon
2019-07-19 19:35 ` bugzilla-daemon
2019-07-19 19:35 ` bugzilla-daemon
2019-07-19 21:28 ` bugzilla-daemon
2019-07-20 22:49 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-204223-201763-ZOtqggK0xm@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox