[Bug 206869] New: [xfstests generic/587]: quota mismatch

[Bug 206869] New: [xfstests generic/587]: quota mismatch

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206869

            Bug ID: 206869
           Summary: [xfstests generic/587]: quota mismatch
           Product: File System
           Version: 2.5
    Kernel Version: xfs-linux xfs-5.3-merge-3
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
          Assignee: filesystem_xfs@kernel-bugs.kernel.org
          Reporter: zlang@redhat.com
        Regression: No

xfstests generic/587 always fails on 512b blocksize XFS:

# ./check generic/587
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 ibm-x3650m4-10 5.6.0-rc5-xfs-whatamess+ #2 SMP
Fri Mar 13 12:21:33 CST 2020
MKFS_OPTIONS  -- -f -m crc=0 -b size=512 /dev/mapper/testvg-scratchdev
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0
/dev/mapper/testvg-scratchdev /mnt/scratch

generic/587 3s ... - output mismatch (see
/root/git/xfstests-dev/results//generic/587.out.bad)
    --- tests/generic/587.out   2020-03-12 11:22:50.036148632 +0800
    +++ /root/git/xfstests-dev/results//generic/587.out.bad     2020-03-17
12:29:40.149766703 +0800
    @@ -1,2 +1,3 @@
     QA output created by 587
    +fsgqa: quota blocks 29KiB, expected 28KiB!
     Silence is golden.
    ...
    (Run 'diff -u /root/git/xfstests-dev/tests/generic/587.out
/root/git/xfstests-dev/results//generic/587.out.bad'  to see the entire diff)
Ran: generic/587
Failures: generic/587
Failed 1 of 1 tests

Only 512b XFS can reproduce this failure.
"-m crc=0 -b size=1024"   PASS
"-m crc=0 -b size=4096"   PASS
"-m crc=1,reflink=1,rmapbt=1 -b size=1024"   PASS
"-m crc=1,reflink=1,rmapbt=1 -b size=4096"   PASS

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206869] [xfstests generic/587]: quota mismatch

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206869

Darrick J. Wong (djwong+kernel@djwong.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djwong+kernel@djwong.org

--- Comment #2 from Darrick J. Wong (djwong+kernel@djwong.org) ---
Created attachment 287959
  --> https://bugzilla.kernel.org/attachment.cgi?id=287959&action=edit
test patch for xfstests

Does the attached patch to generic/587 fix the problem?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206869] [xfstests generic/587]: quota mismatch

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206869

--- Comment #3 from Zorro Lang (zlang@redhat.com) ---
(In reply to Darrick J. Wong from comment #2)
> Created attachment 287959 [details]
> test patch for xfstests
> 
> Does the attached patch to generic/587 fix the problem?

Yes, generic/587 test passed after merge this patch. And this patch looks
smarter than what I write, I'll ack it after you send it to fstests:)

# ./check generic/587
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 xxx-xxxx-xxx 5.6.0-rc5-xfs-whatamess+ #2 SMP Fri
Mar 13 12:21:33 CST 2020
MKFS_OPTIONS  -- -f -m crc=0 -b size=512 /dev/mapper/testvg-scratchdev
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0
/dev/mapper/testvg-scratchdev /mnt/scratch

generic/587 3s ...  3s
Ran: generic/587
Passed all 1 tests

-- 
You are receiving this mail because:
You are watching the assignee of the bug.