[Bug 215783] kernel NULL pointer dereference and general protection fault in fs/xfs/xfs_buf_item_recover.c: xlog_recover_do_reg_buffer() when mount a corrupted image

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=215783

--- Comment #1 from Dave Chinner (david@fromorbit.com) ---
On Thu, Mar 31, 2022 at 08:07:08PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=215783
> - Overview 
> kernel NULL pointer dereference and general protection fault in
> fs/xfs/xfs_buf_item_recover.c:xlog_recover_do_reg_buffer() when mount a
> corrupted image, sometimes cause kernel hang
> 
> - Reproduce 
> tested on kernel 5.17.1, 5.15.32
> 
> $ mkdir mnt
> $ unzip tmp7.zip
> $ ./mount.sh xfs 7  ##NULL pointer derefence
> or
> $ sudo mount -t xfs tmp7.img mnt ##general protection fault
> 
> - Kernel dump

You've now raised 4 bugs that all look very similar and are quite
possibly all caused by the same corruption vector.
Please do some triage on the failure to identify the
source of the corruption that trigger this failure.

If you are going to run some scripted tool to randomly corrupt the
filesystem to find failures, then you have an ethical and moral
responsibility to do some of the work to narrow down and identify
the cause of the failure, not just throw them at someone to do all
the work.

You can automate this - track the corruptions you add to the
filesystem image, then when you have an image that reproduces a
problem, iterate over it removing corruptions until you have just
the minimum set of changes in the image that reproduce the issue.
Then you can cull all the images that trip over the same corruptions
and only report the actual corruption that causes the problem.

Then list those corruptions in the bug report so that we don't have
to do all this triage ourselves to weed out all the duplicates and
noise that all the random corruptions that don't cause crashes
induce.

-Dave.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.