From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E027C433EF for ; Mon, 23 May 2022 10:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233684AbiEWKCr (ORCPT ); Mon, 23 May 2022 06:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233791AbiEWKCp (ORCPT ); Mon, 23 May 2022 06:02:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90BF2B257 for ; Mon, 23 May 2022 03:02:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23CC0611B0 for ; Mon, 23 May 2022 10:02:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 7F3ACC34119 for ; Mon, 23 May 2022 10:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653300154; bh=0Qpf2SCGp0YFtoTSsygvQIWvmKJQa97Peyf+stVZ/EU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Z38Ow2ONpoTaMuBjVb2eP5tfaURCWbt8juONx6gSVDdFkZyC022K5MsWxi+bvsy0x xOU/UrInxM3fpoUwVgB/HXwZKPgetNi2DFEGT97Wos9htp4z02SSn4nffpHmIP5Ta9 9US3NzcEdfNPeJ9LwFgfh83c88IS/S4mkXsrlIs8R8ZWiWeb3RdhBirLCRkv0DzIGz 9w4xyD1cthgE5iIt30JYE4NnKsWe8+3UD0yl3OYInQxgObwiLhCJzwVuRz46NYNQEV WaAnQTs+xnO2o01hXIxX3T656VtSc+u7QaVJMo36YGu1sApF3tvFILBbD78OiVbc4t aQtMLnSqKJHdA== Received: by aws-us-west-2-korg-bugzilla-1.web.codeaurora.org (Postfix, from userid 48) id 6EB30CC13B1; Mon, 23 May 2022 10:02:34 +0000 (UTC) From: bugzilla-daemon@kernel.org To: linux-xfs@vger.kernel.org Subject: [Bug 216007] XFS hangs in iowait when extracting large number of files Date: Mon, 23 May 2022 10:02:33 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo filesystem_xfs@kernel-bugs.kernel.org X-Bugzilla-Product: File System X-Bugzilla-Component: XFS X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: bugzkernelorg8392@araxon.sk X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: filesystem_xfs@kernel-bugs.kernel.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=3D216007 --- Comment #8 from Peter Pavlisko (bugzkernelorg8392@araxon.sk) --- (In reply to Peter Pavlisko from comment #7) > Furthermore, I was able to do a git bisect on this repository: >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git >=20 > The offending commit is this one: >=20 > 9ba0889e2272294bfbb5589b1b180ad2e782b2a4 is the first bad commit > commit 9ba0889e2272294bfbb5589b1b180ad2e782b2a4 > Author: Dave Chinner > Date: Tue Jun 8 09:19:22 2021 -0700 >=20 > xfs: drop the AGI being passed to xfs_check_agi_freecount >=20 > From: Dave Chinner >=20 > Stephen Rothwell reported this compiler warning from linux-next: >=20 > fs/xfs/libxfs/xfs_ialloc.c: In function 'xfs_difree_finobt': > fs/xfs/libxfs/xfs_ialloc.c:2032:20: warning: unused variable 'agi' > [-Wunused-variable] > 2032 | struct xfs_agi *agi =3D agbp->b_addr; >=20 > Which is fallout from agno -> perag conversions that were done in > this function. xfs_check_agi_freecount() is the only user of "agi" > in xfs_difree_finobt() now, and it only uses the agi to get the > current free inode count. We hold that in the perag structure, so > there's not need to directly reference the raw AGI to get this > information. >=20 > The btree cursor being passed to xfs_check_agi_freecount() has a > reference to the perag being operated on, so use that directly in > xfs_check_agi_freecount() rather than passing an AGI. >=20 > Fixes: 7b13c5155182 ("xfs: use perag for ialloc btree cursors") > Reported-by: Stephen Rothwell > Signed-off-by: Dave Chinner > Reviewed-by: Carlos Maiolino > Reviewed-by: Darrick J. Wong > Signed-off-by: Darrick J. Wong >=20 > fs/xfs/libxfs/xfs_ialloc.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) I'm sorry, I made a mistake somewhere while bisecting... This is not the commit. Disregard the quoted message, please. I will try bisecting again. --=20 You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.=