From: bugzilla-daemon@kernel.org
To: linux-xfs@vger.kernel.org
Subject: [Bug 219504] iomap/buffered-io/XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 (and up) for XFS/iomap causing the problems?
Date: Tue, 31 Dec 2024 22:11:36 +0000 [thread overview]
Message-ID: <bug-219504-201763-U0HxfgCrGG@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-219504-201763@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=219504
--- Comment #5 from marco.nelissen@gmail.com ---
With the big caveat that I'm completely unfamiliar with this code, it seems
to me the problem is that here:
https://github.com/torvalds/linux/blame/ccb98ccef0e543c2bd4ef1a72270461957f3d8d0/mm/filemap.c#L2989
"bsz" is a 32-bit type on 32-bit kernels, and so when it gets used later
in that same function to mask the 64-bit "start" value with "~(bsz - 1)",
it's effectively truncating "start" to 32 bits.
This is more or less confirmed by the actual values of "start_byte" and
"punch_start_byte" when that WARN_ON_ONCE in buffer-io.c triggers, with
one being (close to) a 32-bit truncated version of the other.
Changing bsz to a 64-bit type fixes the problem for me.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2024-12-31 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 13:42 [Bug 219504] New: XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 for XFS/iomap causing the problems? bugzilla-daemon
2024-11-21 11:49 ` [Bug 219504] " bugzilla-daemon
2024-11-28 21:09 ` bugzilla-daemon
2024-12-19 13:58 ` bugzilla-daemon
2024-12-19 17:02 ` [Bug 219504] XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 (and up) " bugzilla-daemon
2024-12-30 21:26 ` [Bug 219504] New: XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 " Marco Nelissen
2024-12-30 21:26 ` [Bug 219504] iomap/buffered-io/XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 (and up) " bugzilla-daemon
2024-12-31 22:11 ` [Bug 219504] New: XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 " Marco Nelissen
2024-12-31 22:11 ` bugzilla-daemon [this message]
2025-01-18 14:00 ` [Bug 219504] iomap/buffered-io/XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 (and up) " bugzilla-daemon
2025-01-18 23:51 ` Marco Nelissen
2025-01-18 23:51 ` bugzilla-daemon
2025-01-28 20:00 ` bugzilla-daemon
2025-02-03 10:03 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-219504-201763-U0HxfgCrGG@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox