[Bug 219504] XFS crashes with kernel Version > 6.1.91. Perhaps Changes in kernel 6.1.92 for XFS/iomap causing the problems?

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=219504

Long Li (leo.lilong@huawei.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leo.lilong@huawei.com

--- Comment #1 from Long Li (leo.lilong@huawei.com) ---
Hi, Mike:

Look at the code of 6.1.106:

 970                 /*
 971                  * If there is no more data to scan, all that is left is
to
 972                  * punch out the remaining range.
 973                  */
 974                 if (start_byte == -ENXIO || start_byte == scan_end_byte)
 975                         break;
 976                 if (start_byte < 0) {
 977                         error = start_byte;
 978                         goto out_unlock; 
 979                 }
 980                 WARN_ON_ONCE(start_byte < punch_start_byte);
 981                 WARN_ON_ONCE(start_byte > scan_end_byte);
 982         
 983                 /*
 984                  * We find the end of this contiguous cached data range by
 985                  * seeking from start_byte to the beginning of the next
hole.
 986                  */
 987                 data_end = mapping_seek_hole_data(inode->i_mapping,
start_byte,
 988                                 scan_end_byte, SEEK_HOLE);
 989                 if (data_end < 0) {
 990                         error = data_end;
 991                         goto out_unlock;
 992                 }
 993                 WARN_ON_ONCE(data_end <= start_byte);  
 994                 WARN_ON_ONCE(data_end > scan_end_byte);
 995 
 996                 error = iomap_write_delalloc_scan(inode,
&punch_start_byte,
 997                                 start_byte, data_end, punch);

Looking at your warning stack, it reminds me of a problem[1] I tried to solve
before, but it seems different. In my case, there was only a warning on line
993. Perhaps it's not the same issue. Below is a link to my attempted fix
patch, which wasn't accepted, but hopefully it can be helpful to you.

[1]
https://patchwork.kernel.org/project/xfs/patch/20231216115559.3823359-1-leo.lilong@huawei.com/

Long Li

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.