public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Olaf Weber <olaf@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] default to inode64 on 64-bit systems
Date: Tue, 07 Jul 2009 10:59:37 +0200	[thread overview]
Message-ID: <bzyhbxoc1hi.fsf@fransum.emea.sgi.com> (raw)
In-Reply-To: <20090706184257.GA18107@infradead.org> (Christoph Hellwig's message of "Mon, 6 Jul 2009 14:42:57 -0400")

Christoph Hellwig writes:
> On Mon, Jul 06, 2009 at 01:25:34PM -0500, Eric Sandeen wrote:

>> I'm tiring of telling people to use the inode64 mount option
>> when they are experiencing bad performance on large xfs 
>> filesystems...
>> 
>> 32-bit userspace is still largely broken when it comes to still
>> using 32-bit stat calls, but on 64-bit systems this should be
>> safe.
>> 
>> The only problem here is moving the disk onto a 32-bit system, or using
>> 32-bit apps.  But I think it's a small risk.
>> 
>> What do we think about the following?

> Looks good to me, but it could use a comment in the code explaining why
> we do this.

Making inode64 the default on 64 bit systems seems like a good idea to
me.  But would it not be advisable to have a mount option that forces
the old behaviour, just in case?  Something like "broken32bituserspace"
(or maybe "inode32").

-- 
Olaf Weber                 SGI               Phone:  +31(0)30-6696752
                           Veldzigt 2b       Fax:    +31(0)30-6696799
Technical Lead             3454 PW de Meern  Vnet:   955-7151
Storage Software           The Netherlands   Email:  olaf@sgi.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-07-07  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 18:25 [PATCH, RFC] default to inode64 on 64-bit systems Eric Sandeen
2009-07-06 18:42 ` Christoph Hellwig
2009-07-07  8:59   ` Olaf Weber [this message]
2009-07-07 10:12     ` Michael Weissenbacher
2009-07-07  9:38 ` Matthias Schniedermeyer
2009-07-07 14:06   ` Eric Sandeen
2009-07-07 18:13     ` Matthias Schniedermeyer
2009-07-07 18:17       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bzyhbxoc1hi.fsf@fransum.emea.sgi.com \
    --to=olaf@sgi.com \
    --cc=hch@infradead.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox