From: Olaf Weber <olaf@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfs_io: fix test for fallocate on 32bit boxes
Date: Mon, 15 Jun 2009 22:12:13 +0200 [thread overview]
Message-ID: <bzyocspdzoi.fsf@fransum.emea.sgi.com> (raw)
In-Reply-To: <4A36A448.4060406@sandeen.net> (Eric Sandeen's message of "Mon, 15 Jun 2009 14:43:04 -0500")
Looks good.
Reviewed-by: Olaf Weber <olaf@sgi.com>
Eric Sandeen writes:
> xfs_io: fix test for fallocate on 32bit boxes
> As per Red Hat bug 500487, fallocate64 is missing in glibc,
> so attempts to build with fallocate and _FILE_OFFSET_BITS=64
> will fail.
> So, change the config to test the way we will build, and
> it'll fail properly on x86 until glibc gets fixed.
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
> index 1ac4666..1c1859d 100644
> --- a/m4/package_libcdev.m4
> +++ b/m4/package_libcdev.m4
> @@ -105,6 +105,9 @@ AC_DEFUN([AC_HAVE_GETMNTINFO],
> AC_DEFUN([AC_HAVE_FALLOCATE],
> [ AC_MSG_CHECKING([for fallocate])
> AC_TRY_LINK([
> +#define _GNU_SOURCE
> +#define _FILE_OFFSET_BITS 64
> +#include <fcntl.h>
> #include <linux/falloc.h>
> ], [
> fallocate(0, 0, 0, 0);
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Olaf Weber SGI Phone: +31(0)30-6696752
Veldzigt 2b Fax: +31(0)30-6696799
Technical Lead 3454 PW de Meern Vnet: 955-7151
Storage Software The Netherlands Email: olaf@sgi.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-06-15 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 19:43 xfs_io: fix test for fallocate on 32bit boxes Eric Sandeen
2009-06-15 20:12 ` Olaf Weber [this message]
2009-06-16 14:04 ` Christoph Hellwig
2009-06-16 15:04 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bzyocspdzoi.fsf@fransum.emea.sgi.com \
--to=olaf@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox