From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fransum.emea.sgi.com (fransum.emea.sgi.com [144.253.208.10]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n5FKBqiW123668 for ; Mon, 15 Jun 2009 15:11:53 -0500 Subject: Re: xfs_io: fix test for fallocate on 32bit boxes References: <4A36A448.4060406@sandeen.net> From: Olaf Weber Date: Mon, 15 Jun 2009 22:12:13 +0200 In-Reply-To: <4A36A448.4060406@sandeen.net> (Eric Sandeen's message of "Mon, 15 Jun 2009 14:43:04 -0500") Message-ID: MIME-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss Looks good. Reviewed-by: Olaf Weber Eric Sandeen writes: > xfs_io: fix test for fallocate on 32bit boxes > As per Red Hat bug 500487, fallocate64 is missing in glibc, > so attempts to build with fallocate and _FILE_OFFSET_BITS=64 > will fail. > So, change the config to test the way we will build, and > it'll fail properly on x86 until glibc gets fixed. > Signed-off-by: Eric Sandeen > --- > diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4 > index 1ac4666..1c1859d 100644 > --- a/m4/package_libcdev.m4 > +++ b/m4/package_libcdev.m4 > @@ -105,6 +105,9 @@ AC_DEFUN([AC_HAVE_GETMNTINFO], > AC_DEFUN([AC_HAVE_FALLOCATE], > [ AC_MSG_CHECKING([for fallocate]) > AC_TRY_LINK([ > +#define _GNU_SOURCE > +#define _FILE_OFFSET_BITS 64 > +#include > #include > ], [ > fallocate(0, 0, 0, 0); > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs -- Olaf Weber SGI Phone: +31(0)30-6696752 Veldzigt 2b Fax: +31(0)30-6696799 Technical Lead 3454 PW de Meern Vnet: 955-7151 Storage Software The Netherlands Email: olaf@sgi.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs