From: Nikolay Borisov <nborisov@suse.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH v2] fiemap: Allow to specify range to fiemap
Date: Thu, 10 Aug 2017 19:46:35 +0300 [thread overview]
Message-ID: <c254f712-e2bd-502b-515f-5ba20097bffd@suse.com> (raw)
In-Reply-To: <20170810161322.GV24087@magnolia>
On 10.08.2017 19:13, Darrick J. Wong wrote:
> We don't decrement len each time through the ioctl loop? Doesn't that
> cause us to request and retrieve rows for ranges we don't want?
Hm, you are right, I believe on every iteration we should do:
len -= last_logical - start_offset
next prev parent reply other threads:[~2017-08-10 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 11:07 [PATCH] fiemap: Allow to specify range to fiemap Nikolay Borisov
2017-08-10 12:04 ` Dave Chinner
2017-08-10 12:30 ` [PATCH v2] " Nikolay Borisov
2017-08-10 16:13 ` Darrick J. Wong
2017-08-10 16:46 ` Nikolay Borisov [this message]
2017-08-10 21:12 ` Darrick J. Wong
2017-08-10 21:22 ` Eric Sandeen
2017-08-10 21:57 ` Eric Sandeen
2017-08-11 5:38 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c254f712-e2bd-502b-515f-5ba20097bffd@suse.com \
--to=nborisov@suse.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox