public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chuck Lever" <cel@kernel.org>
To: "Steve French" <smfrench@gmail.com>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>,
	"Namjae Jeon" <linkinjeon@kernel.org>,
	"Sungjong Seo" <sj1557.seo@samsung.com>,
	"Yuezhang Mo" <yuezhang.mo@sony.com>,
	almaz.alexandrovich@paragon-software.com,
	"Viacheslav Dubeyko" <slava@dubeyko.com>,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	frank.li@vivo.com, "Theodore Tso" <tytso@mit.edu>,
	adilger.kernel@dilger.ca, "Carlos Maiolino" <cem@kernel.org>,
	"Steve French" <sfrench@samba.org>,
	"Paulo Alcantara" <pc@manguebit.org>,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Shyam Prasad N" <sprasad@microsoft.com>,
	"Trond Myklebust" <trondmy@kernel.org>,
	"Anna Schumaker" <anna@kernel.org>,
	"Jaegeuk Kim" <jaegeuk@kernel.org>, "Chao Yu" <chao@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	senozhatsky@chromium.org, "Chuck Lever" <chuck.lever@oracle.com>
Subject: Re: [PATCH v9 10/17] cifs: Implement fileattr_get for case sensitivity
Date: Wed, 22 Apr 2026 21:35:47 -0400	[thread overview]
Message-ID: <c41111fd-2473-4fdd-8e1e-285b9e24e631@app.fastmail.com> (raw)
In-Reply-To: <CAH2r5muvUVY8FD6ZM+ARecM8evjejB15n0Ea9Z=GGn=i5aKFNA@mail.gmail.com>


On Wed, Apr 22, 2026, at 8:59 PM, Steve French wrote:
> Acked-by: Steve French <stfrench@microsoft.com>
>
> Do you know which xfstests this would enable?  IIRC a few of them
> depend on the fs supporting fileattr_get

Thanks for the Ack.

I checked the current xfstests tree and couldn’t find a test that flips
from notrun to run on cifs just from adding ->fileattr_get. generic/556
is the existing case-folding test, but _has_casefold_kernel_support in
common/casefold hard-codes ext4/f2fs/tmpfs. Enabling it on cifs would
need a new mechanism in common/casefold plus a mount-option-driven
variant (the cifs reporting keys off nocase, not a per-inode flag), so
that's a separate piece of work.

The practical effect on the existing suite is that fsstress's getattr_f
now returns success instead of ENOTTY on cifs, which quiets some noise
but doesn't gate any test. To actually exercise the new FS_XFLAG_CASEFOLD
reporting I think a new test (or a generalization of generic/556) would
have to be written.


-- 
Chuck Lever

  reply	other threads:[~2026-04-23  1:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 23:29 [PATCH v9 00/17] Exposing case folding behavior Chuck Lever
2026-04-22 23:29 ` [PATCH v9 01/17] fs: Move file_kattr initialization to callers Chuck Lever
2026-04-22 23:38   ` Darrick J. Wong
2026-04-22 23:29 ` [PATCH v9 02/17] fs: Add case sensitivity flags to file_kattr Chuck Lever
2026-04-22 23:29 ` [PATCH v9 03/17] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:29 ` [PATCH v9 04/17] exfat: " Chuck Lever
2026-04-22 23:29 ` [PATCH v9 05/17] ntfs3: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 06/17] hfs: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 07/17] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-04-22 23:30 ` [PATCH v9 08/17] ext4: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 09/17] xfs: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 10/17] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-23  0:59   ` Steve French
2026-04-23  1:35     ` Chuck Lever [this message]
2026-04-22 23:30 ` [PATCH v9 11/17] nfs: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 12/17] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-04-22 23:30 ` [PATCH v9 13/17] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:30 ` [PATCH v9 14/17] isofs: " Chuck Lever
2026-04-22 23:30 ` [PATCH v9 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-04-22 23:30 ` [PATCH v9 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-04-22 23:30 ` [PATCH v9 17/17] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c41111fd-2473-4fdd-8e1e-285b9e24e631@app.fastmail.com \
    --to=cel@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=chao@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hansg@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sj1557.seo@samsung.com \
    --cc=slava@dubeyko.com \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox