From: Alex Elder <elder@ieee.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't print warnings when xfs_log_force fails
Date: Thu, 29 Dec 2016 13:00:12 -0600 [thread overview]
Message-ID: <cb2e778f-8215-bb0f-ed02-7518f7729c1a@ieee.org> (raw)
In-Reply-To: <20161229180933.GA16118@lst.de>
On 12/29/2016 12:09 PM, Christoph Hellwig wrote:
> On Thu, Dec 29, 2016 at 08:42:08AM -0600, Alex Elder wrote:
>> This sounds like a good idea, though I haven't really reviewed
>> the code itself. But I'd say a one line comment indicating why
>> errors from _xfs_log_force() are being ignored might be good.
>
> I don't really know the answer, but it probabls is: some callers
> shouldn't ignore it and others can't handle it either. Maybe I'll
> need to some further work in this area, but it's not really
> related to dropping the message.
>
I actually misspoke.
What I *meant* to say was that a comment about why we don't
want to log a message in these spots might be nice. But
now I'm less interested in that and more interested in
why errors from _xfs_log_force*() can be ignored.
Anyway, I won't claim to have reviewed this, but your change
makes sense to me.
-Alex
next prev parent reply other threads:[~2016-12-29 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 8:23 make log force warnings less annoying Christoph Hellwig
2016-12-29 8:23 ` [PATCH] xfs: don't print warnings when xfs_log_force fails Christoph Hellwig
2016-12-29 14:42 ` Alex Elder
2016-12-29 18:09 ` Christoph Hellwig
2016-12-29 19:00 ` Alex Elder [this message]
2017-01-02 9:28 ` Carlos Maiolino
2017-01-09 11:08 ` Christoph Hellwig
2017-01-09 21:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2e778f-8215-bb0f-ed02-7518f7729c1a@ieee.org \
--to=elder@ieee.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).