From: "Bhagi rathi" <jahnu77@gmail.com>
To: "donaldd@sgi.com" <donaldd@sgi.com>
Cc: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com
Subject: Re: TAKE 970240 - kill BMAPI_DEVICE
Date: Fri, 14 Sep 2007 00:53:20 +0530 [thread overview]
Message-ID: <cc7060690709131223o7bb4f75sd6a42e30a6a078c3@mail.gmail.com> (raw)
In-Reply-To: <20070913043416.CCFAC2F9EBDB@linuxbuild.melbourne.sgi.com>
Can one of you let me know the process of submitting changes?
Problem: Real time flag set on a regular file can race with directio which
can lead to
incorrect real time device for iomap in xfs_vm_direct_IO. This
can happen
only on the first I/O to the file as we don't set real time
flag if any of
the extents or delayed blocks present.
Fix:
xfs_setattr() {
...
if (!(mask & XFS_AT_SIZE)) {
if (need_io_lock && vap->va_xflags & XFS_XFLAG_REALTIME)
lock_flags |= XFS_IOLOCK_EXCL;
.....
}
...
}
-Thanks,
Saradhi.
On 9/13/07, donaldd@sgi.com <donaldd@sgi.com> wrote:
>
> kill BMAPI_DEVICE
>
> There is no reason to go into the iomap machinery just to get the
> right block device for an inode. Instead look at the realtime flag
> in the inode and grab the right device from the mount structure.
>
> I created a new helper, xfs_find_bdev_for_inode instead of opencoding
> it because I plan to use it in other places in the future.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de >
>
> Date: Thu Sep 13 14:33:42 AEST 2007
> Workarea: linuxbuild.melbourne.sgi.com:/home/donaldd/isms/2.6.x-xfs
> Inspected by: hch@lst.de
>
> The following file(s) were checked into:
> longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
>
>
> Modid: xfs-linux-melb:xfs-kern:29680a
> fs/xfs/xfs_iomap.h - 1.11 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> xfs_iomap.h.diff?r1=text&tr1=1.11&r2=text&tr2=1.10&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_iomap.h.diff?r1=text&tr1=1.11&r2=text&tr2=1.10&f=h
> - kill BMAPI_DEVICE
>
> fs/xfs/xfs_iomap.c - 1.55 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> xfs_iomap.c.diff?r1=text&tr1=1.55&r2=text&tr2=1.54&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_iomap.c.diff?r1=text&tr1=1.55&r2=text&tr2=1.54&f=h
> - kill BMAPI_DEVICE
>
> fs/xfs/linux-2.6/xfs_aops.c - 1.154 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> linux-2.6/xfs_aops.c.diff?r1=text&tr1=1.154&r2=text&tr2=1.153&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_aops.c.diff?r1=text&tr1=1.154&r2=text&tr2=1.153&f=h
> - kill BMAPI_DEVICE
>
>
>
>
[[HTML alternate version deleted]]
next prev parent reply other threads:[~2007-09-13 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 4:34 TAKE 970240 - kill BMAPI_DEVICE donaldd
2007-09-13 19:23 ` Bhagi rathi [this message]
2007-09-13 20:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7060690709131223o7bb4f75sd6a42e30a6a078c3@mail.gmail.com \
--to=jahnu77@gmail.com \
--cc=donaldd@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox