Re: TAKE 981498 - Use KM_NOFS for debug trace buffers

["Bhagi rathi" <jahnu77@gmail.com>]

On Thu, Aug 7, 2008 at 11:13 PM, Bhagi rathi <jahnu77@gmail.com> wrote:

>
>
> On Thu, Aug 7, 2008 at 1:49 AM, Dave Chinner <david@fromorbit.com> wrote:
>
>> On Wed, Aug 06, 2008 at 10:42:15PM +0530, Bhagi rathi wrote:
>> > I couldn't get a chance to read the diff's completely. If I click on
>> > Lachlan's url for diff's, I couldn't access them. It looks to me that
>> > the issue is not just with trace buffers. It can extend to xfs_iformat
>> > as well. The same dead-lock can spring via
>> >
>> > xfs_iread -> xfs_iformat -> xfs_iformat_extents -> xfs_iext_add ->
>> > xfs_iext_inline_to_direct -> which can do kmem_alloc with
>> > KM_SLEEP flag.
>>
>> Fixed already:
>>
>>
>> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=commit;h=8c6266658cb76e282c14cb92f8ba5a1c674f4928
>>
>
>  Thanks Dave. However, My concern is just not one allocation. We
>  need to clean all allocations that can re-enter to file-system.
>  I see that this issue exists in attributes format for i_afp allocations.
>  It may exist with local format of data and attributes too.
>
>  xfs_iread->xfs_iformat->xfs_iformat_local.
>

  Is the above issue fixed already? I see this existing in latest linux
  kernel.


>
>  Are we safe that we fixed all these real problems by looking
>  into possible allocations that will enter into file-system? The
>  problem with trace buffers is telling us to clean this code path.
>
>  By the way, I browse the source code from lxr.linux.no.
>  If I have to browse the latest xfs source code with linux
>  kernel that is used at SGI, how can I do that?
>

 Any pointers on this? I wish to setup my own xfs development enviroment
 and details on this will be helpful.

Cheers,
Bhagi.

>
>
>  Cheers,
>  Bhagi.
>
>>
>> Cheers,
>>
>> Dave.
>> --
>> Dave Chinner
>> david@fromorbit.com
>>
>
>


[[HTML alternate version deleted]]