Re: [PATCH 1/6] generic/765: fix a few issues

[John Garry <john.g.garry@oracle.com>]

On 15/05/2025 22:50, Catherine Hoang wrote:
>>> Are you asking if _require_xfs_io_command should seek out the filesystem
>>> block size, and use that for the buffer and write size arguments instead
>>> of hardcoding 4k?  For atomic writes, maybe it should be doing this,
>>> since the fs blocksize could be 64k.
>> I was just a bit thrown by how we need to specify -b $size with -A to actually write $size atomically.
> There was a discussion about this a while back about why -b $bsize
> was needed when using pwrite, although I’m not sure if it still applies
> or if the way atomic writes works has been changed since then.
> 
> https://lore.kernel.org/linux-xfs/ 
> a6a2dc60f34ac353e5ea628a9ea1feba4800be7a.camel@linux.ibm.com/

Yes, and the xfs_io behaviour for -A is my focus here. I don't like how 
it splits by default (for $size > default blocksize).

We could have had behaviour that default blocksize for -A is $size. 
Maybe that just complicates things. Anyway, I think that ship has sailed.

Thanks,
John