From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Cc: "Cc : Hans Holmberg" <hans.holmberg@wdc.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: add a separate bio_set for spliting GC writes
Date: Wed, 29 Jul 2026 13:07:44 +0900 [thread overview]
Message-ID: <cf06355e-0974-480f-8649-64abd2cbf433@kernel.org> (raw)
In-Reply-To: <20260728080650.1777545-2-hch@lst.de>
On 7/28/26 17:06, Christoph Hellwig wrote:
> Allocating the new bio for a split from the same pool as the original
> one can deadlock under memory pressure. Add a separate pool for
> splitting GC write bios to avoid this.
>
> Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me, but the commit message would be better with an explanation of
how the deadlock can happen, as I do not think it is that obvious.
Regardless,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-07-29 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 8:06 zoned GC fix Christoph Hellwig
2026-07-28 8:06 ` [PATCH 1/2] xfs: add a separate bio_set for spliting GC writes Christoph Hellwig
2026-07-28 15:27 ` Darrick J. Wong
2026-07-29 4:07 ` Damien Le Moal [this message]
2026-07-28 8:06 ` [PATCH 2/2] xfs: add a comment to describe xfs_gc_bio.victim_rtg Christoph Hellwig
2026-07-28 15:27 ` Darrick J. Wong
2026-07-29 4:05 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2026-07-29 13:02 zoned GC fix v2 Christoph Hellwig
2026-07-29 13:02 ` [PATCH 1/2] xfs: add a separate bio_set for spliting GC writes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf06355e-0974-480f-8649-64abd2cbf433@kernel.org \
--to=dlemoal@kernel.org \
--cc=cem@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox