public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [Trivial PATCH 00/33] Remove uses of typedef ctl_table
@ 2013-06-14  2:37 Joe Perches
  2013-06-14  2:37 ` [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2013-06-14  2:37 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: linux-mips, linux-nfs, linux-ia64, keyrings, linux-scsi,
	linux-s390, linux-rdma, netdev, linux-kernel, codalist,
	linux-raid, linux-ntfs-dev, linux-security-module, linux-cachefs,
	ocfs2-devel, linux-fsdevel, openipmi-developer, xfs, linuxppc-dev,
	linux-mm, linux-arm-kernel

It's clearer to use struct ctl_table instead

Joe Perches (33):
  arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table
  frv: Convert use of typedef ctl_table to struct ctl_table
  ia64: crash: Convert use of typedef ctl_table to struct ctl_table
  mips: lasat: sysctl: Convert use of typedef ctl_table to struct ctl_table
  powerpc: idle: Convert use of typedef ctl_table to struct ctl_table
  s390: Convert use of typedef ctl_table to struct ctl_table
  tile: proc: Convert use of typedef ctl_table to struct ctl_table
  x86: vdso: Convert use of typedef ctl_table to struct ctl_table
  cdrom: Convert use of typedef ctl_table to struct ctl_table
  char: Convert use of typedef ctl_table to struct ctl_table
  infiniband: Convert use of typedef ctl_table to struct ctl_table
  macintosh: Convert use of typedef ctl_table to struct ctl_table
  md: Convert use of typedef ctl_table to struct ctl_table
  sgi: xpc: Convert use of typedef ctl_table to struct ctl_table
  parport: Convert use of typedef ctl_table to struct ctl_table
  scsi_sysctl: Convert use of typedef ctl_table to struct ctl_table
  coda: Convert use of typedef ctl_table to struct ctl_table
  fscache: Convert use of typedef ctl_table to struct ctl_table
  lockd: Convert use of typedef ctl_table to struct ctl_table
  nfs: Convert use of typedef ctl_table to struct ctl_table
  inotify: Convert use of typedef ctl_table to struct ctl_table
  ntfs: Convert use of typedef ctl_table to struct ctl_table
  ocfs2: Convert use of typedef ctl_table to struct ctl_table
  quota: Convert use of typedef ctl_table to struct ctl_table
  xfs: Convert use of typedef ctl_table to struct ctl_table
  fs: Convert use of typedef ctl_table to struct ctl_table
  key: Convert use of typedef ctl_table to struct ctl_table
  ipv6: Convert use of typedef ctl_table to struct ctl_table
  ndisc: Convert use of typedef ctl_table to struct ctl_table
  ipc: Convert use of typedef ctl_table to struct ctl_table
  sysctl: Convert use of typedef ctl_table to struct ctl_table
  mm: Convert use of typedef ctl_table to struct ctl_table
  security: keys: Convert use of typedef ctl_table to struct ctl_table

 arch/arm/kernel/isa.c              |  6 ++--
 arch/frv/kernel/pm.c               |  8 +++---
 arch/frv/kernel/sysctl.c           |  4 +--
 arch/ia64/kernel/crash.c           |  4 +--
 arch/ia64/kernel/perfmon.c         |  6 ++--
 arch/mips/lasat/sysctl.c           | 14 ++++-----
 arch/powerpc/kernel/idle.c         |  4 +--
 arch/s390/appldata/appldata_base.c | 16 +++++------
 arch/s390/kernel/debug.c           |  4 +--
 arch/s390/mm/cmm.c                 |  6 ++--
 arch/tile/kernel/proc.c            |  4 +--
 arch/x86/vdso/vdso32-setup.c       |  4 +--
 drivers/cdrom/cdrom.c              | 10 +++----
 drivers/char/hpet.c                |  6 ++--
 drivers/char/ipmi/ipmi_poweroff.c  |  6 ++--
 drivers/char/random.c              |  8 +++---
 drivers/char/rtc.c                 |  6 ++--
 drivers/infiniband/core/ucma.c     |  2 +-
 drivers/macintosh/mac_hid.c        |  8 +++---
 drivers/md/md.c                    |  6 ++--
 drivers/misc/sgi-xp/xpc_main.c     |  6 ++--
 drivers/parport/procfs.c           | 58 +++++++++++++++++++-------------------
 drivers/scsi/scsi_sysctl.c         |  6 ++--
 fs/coda/sysctl.c                   |  4 +--
 fs/dcache.c                        |  2 +-
 fs/drop_caches.c                   |  2 +-
 fs/eventpoll.c                     |  2 +-
 fs/file_table.c                    |  4 +--
 fs/fscache/main.c                  |  4 +--
 fs/inode.c                         |  2 +-
 fs/lockd/svc.c                     |  6 ++--
 fs/nfs/nfs4sysctl.c                |  6 ++--
 fs/nfs/sysctl.c                    |  6 ++--
 fs/notify/inotify/inotify_user.c   |  2 +-
 fs/ntfs/sysctl.c                   |  4 +--
 fs/ocfs2/stackglue.c               |  8 +++---
 fs/quota/dquot.c                   |  6 ++--
 fs/xfs/xfs_sysctl.c                | 26 ++++++++---------
 include/linux/key.h                |  2 +-
 include/net/ipv6.h                 |  4 +--
 include/net/ndisc.h                |  2 +-
 ipc/ipc_sysctl.c                   | 14 ++++-----
 ipc/mq_sysctl.c                    | 10 +++----
 kernel/sysctl.c                    |  2 +-
 kernel/utsname_sysctl.c            |  6 ++--
 mm/page-writeback.c                |  2 +-
 mm/page_alloc.c                    | 15 +++++-----
 security/keys/sysctl.c             |  2 +-
 48 files changed, 174 insertions(+), 171 deletions(-)

-- 
1.8.1.2.459.gbcd45b4.dirty

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table
  2013-06-14  2:37 [Trivial PATCH 00/33] Remove uses of typedef ctl_table Joe Perches
@ 2013-06-14  2:37 ` Joe Perches
  2013-06-14  5:21   ` Dave Chinner
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2013-06-14  2:37 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Ben Myers, Alex Elder, linux-kernel, xfs

This typedef is unnecessary and should just be removed.

Signed-off-by: Joe Perches <joe@perches.com>
---
 fs/xfs/xfs_sysctl.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c
index 2801b5c..1743b9f 100644
--- a/fs/xfs/xfs_sysctl.c
+++ b/fs/xfs/xfs_sysctl.c
@@ -25,11 +25,11 @@ static struct ctl_table_header *xfs_table_header;
 #ifdef CONFIG_PROC_FS
 STATIC int
 xfs_stats_clear_proc_handler(
-	ctl_table	*ctl,
-	int		write,
-	void		__user *buffer,
-	size_t		*lenp,
-	loff_t		*ppos)
+	struct ctl_table	*ctl,
+	int			write,
+	void			__user *buffer,
+	size_t			*lenp,
+	loff_t			*ppos)
 {
 	int		c, ret, *valp = ctl->data;
 	__uint32_t	vn_active;
@@ -55,11 +55,11 @@ xfs_stats_clear_proc_handler(
 
 STATIC int
 xfs_panic_mask_proc_handler(
-	ctl_table	*ctl,
-	int		write,
-	void		__user *buffer,
-	size_t		*lenp,
-	loff_t		*ppos)
+	struct ctl_table	*ctl,
+	int			write,
+	void			__user *buffer,
+	size_t			*lenp,
+	loff_t			*ppos)
 {
 	int		ret, *valp = ctl->data;
 
@@ -74,7 +74,7 @@ xfs_panic_mask_proc_handler(
 }
 #endif /* CONFIG_PROC_FS */
 
-static ctl_table xfs_table[] = {
+static struct ctl_table xfs_table[] = {
 	{
 		.procname	= "irix_sgid_inherit",
 		.data		= &xfs_params.sgid_inherit.val,
@@ -227,7 +227,7 @@ static ctl_table xfs_table[] = {
 	{}
 };
 
-static ctl_table xfs_dir_table[] = {
+static struct ctl_table xfs_dir_table[] = {
 	{
 		.procname	= "xfs",
 		.mode		= 0555,
@@ -236,7 +236,7 @@ static ctl_table xfs_dir_table[] = {
 	{}
 };
 
-static ctl_table xfs_root_table[] = {
+static struct ctl_table xfs_root_table[] = {
 	{
 		.procname	= "fs",
 		.mode		= 0555,
-- 
1.8.1.2.459.gbcd45b4.dirty

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table
  2013-06-14  2:37 ` [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table Joe Perches
@ 2013-06-14  5:21   ` Dave Chinner
  2013-06-14  5:33     ` Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2013-06-14  5:21 UTC (permalink / raw)
  To: Joe Perches; +Cc: Ben Myers, Alex Elder, Jiri Kosina, linux-kernel, xfs

On Thu, Jun 13, 2013 at 07:37:50PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Looks fine, Joe.

Acked-by: Dave Chinner <dchinner@redhat.com>

How do you want us to handle this? Push it through the XFS tree or
are you going to send it on up yourself?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table
  2013-06-14  5:21   ` Dave Chinner
@ 2013-06-14  5:33     ` Joe Perches
  2013-06-14  6:18       ` Dave Chinner
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2013-06-14  5:33 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Ben Myers, Alex Elder, Jiri Kosina, linux-kernel, xfs

On Fri, 2013-06-14 at 15:21 +1000, Dave Chinner wrote:
> On Thu, Jun 13, 2013 at 07:37:50PM -0700, Joe Perches wrote:
> > This typedef is unnecessary and should just be removed.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Looks fine, Joe.
> 
> Acked-by: Dave Chinner <dchinner@redhat.com>
> 
> How do you want us to handle this? Push it through the XFS tree or
> are you going to send it on up yourself?

Hi Dave.

I'd prefer you pick it up.

These are all pretty trivial patches, but Jiri
typically doesn't pick them up for months.

I expect I'll have to resend whatever maintainers
don't pick up in 6 months or so.


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table
  2013-06-14  5:33     ` Joe Perches
@ 2013-06-14  6:18       ` Dave Chinner
  2013-06-17 22:39         ` Ben Myers
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2013-06-14  6:18 UTC (permalink / raw)
  To: Joe Perches; +Cc: Ben Myers, Alex Elder, Jiri Kosina, linux-kernel, xfs

On Thu, Jun 13, 2013 at 10:33:26PM -0700, Joe Perches wrote:
> On Fri, 2013-06-14 at 15:21 +1000, Dave Chinner wrote:
> > On Thu, Jun 13, 2013 at 07:37:50PM -0700, Joe Perches wrote:
> > > This typedef is unnecessary and should just be removed.
> > > 
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > 
> > Looks fine, Joe.
> > 
> > Acked-by: Dave Chinner <dchinner@redhat.com>
> > 
> > How do you want us to handle this? Push it through the XFS tree or
> > are you going to send it on up yourself?
> 
> Hi Dave.
> 
> I'd prefer you pick it up.
> 
> These are all pretty trivial patches, but Jiri
> typically doesn't pick them up for months.
> 
> I expect I'll have to resend whatever maintainers
> don't pick up in 6 months or so.

No worries, I'll add it to my current 3.11 patchset.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table
  2013-06-14  6:18       ` Dave Chinner
@ 2013-06-17 22:39         ` Ben Myers
  0 siblings, 0 replies; 6+ messages in thread
From: Ben Myers @ 2013-06-17 22:39 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Joe Perches, Alex Elder, Jiri Kosina, linux-kernel, xfs

Hey Fellas,

On Fri, Jun 14, 2013 at 04:18:07PM +1000, Dave Chinner wrote:
> On Thu, Jun 13, 2013 at 10:33:26PM -0700, Joe Perches wrote:
> > On Fri, 2013-06-14 at 15:21 +1000, Dave Chinner wrote:
> > > On Thu, Jun 13, 2013 at 07:37:50PM -0700, Joe Perches wrote:
> > > > This typedef is unnecessary and should just be removed.
> > > > 
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > 
> > > Looks fine, Joe.
> > > 
> > > Acked-by: Dave Chinner <dchinner@redhat.com>
> > > 
> > > How do you want us to handle this? Push it through the XFS tree or
> > > are you going to send it on up yourself?
> > 
> > Hi Dave.
> > 
> > I'd prefer you pick it up.
> > 
> > These are all pretty trivial patches, but Jiri
> > typically doesn't pick them up for months.
> > 
> > I expect I'll have to resend whatever maintainers
> > don't pick up in 6 months or so.
> 
> No worries, I'll add it to my current 3.11 patchset.

Applied it. No need to repost. Thanks Joe!

Reviewed-by: Ben Myers <bpm@sgi.com>

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-17 22:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14  2:37 [Trivial PATCH 00/33] Remove uses of typedef ctl_table Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 25/33] xfs: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-06-14  5:21   ` Dave Chinner
2013-06-14  5:33     ` Joe Perches
2013-06-14  6:18       ` Dave Chinner
2013-06-17 22:39         ` Ben Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox