Re: [PATCH 23/33] xfs: convert xfs_buf_log_format_t typedef to struct

Andrey Albershteyn
2025-12-04T10:00:57Z

On 2025-12-04 10:32:02, Christoph Hellwig wrote:
> On Wed, Dec 03, 2025 at 08:09:48PM +0100, Andrey Albershteyn wrote:
> > Convert xfs_buf_log_format_t to struct and retab arguments for new
> > longer type.
>
> I think all these patches should go before the removal?

oh right, will move them before

>
> >
> > Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
> > ---
> > include/xfs_trans.h | 10 +++++-----
> > logprint/log_print_all.c | 18 +++++++++---------
> > 2 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/include/xfs_trans.h b/include/xfs_trans.h
> > index d7d3904119..a3e8a000c9 100644
> > --- a/include/xfs_trans.h
> > +++ b/include/xfs_trans.h
> > @@ -46,11 +46,11 @@
> > };
> >
> > typedef struct xfs_buf_log_item {
> > - xfs_log_item_t bli_item; /* common item structure */
> > - struct xfs_buf *bli_buf; /* real buffer pointer */
> > - unsigned int bli_flags; /* misc flags */
> > - unsigned int bli_recur; /* recursion count */
> > - xfs_buf_log_format_t __bli_format; /* in-log header */
> > + xfs_log_item_t bli_item; /* common item structure */
>
> This should be struct xfs_log_item.

hmm, I think this one (and xfs_buf_log_item_t) wasn't propagated to
xfsprogs. I see your commit in kernel but that's from 2019.

>
> > diff --git a/logprint/log_print_all.c b/logprint/log_print_all.c
> > index 39946f32d4..bbea6a8f07 100644
> > --- a/logprint/log_print_all.c
> > +++ b/logprint/log_print_all.c
>
> And this clashed with the series I had, which also splits things up.
> But I guess we should just do the quick conversion given that you've
> done all the work and I was too slow.
>

If you have more cleanups I can also include them, I want to prepare
everything for soonish v6.18 release and include that fix for
xfs_quota (which I will probably send today, not sure if reporter
will send the fix).

--
- Andrey