Re: [PATCH 23/33] xfs: convert xfs_buf_log_format_t typedef to struct

Christoph Hellwig
2025-12-04T10:08:24Z

On Thu, Dec 04, 2025 at 11:00:51AM +0100, Andrey Albershteyn wrote:
> > > + xfs_log_item_t bli_item; /* common item structure */
> >
> > This should be struct xfs_log_item.
>
> hmm, I think this one (and xfs_buf_log_item_t) wasn't propagated to
> xfsprogs. I see your commit in kernel but that's from 2019.

Oops. I can take care of that, but for anything you touch anyway,
please avoid the typedef.

> > And this clashed with the series I had, which also splits things up.
> > But I guess we should just do the quick conversion given that you've
> > done all the work and I was too slow.
> >
>
> If you have more cleanups I can also include them, I want to prepare
> everything for soonish v6.18 release and include that fix for
> xfs_quota (which I will probably send today, not sure if reporter
> will send the fix).

I have a quite a bit of dusting off for logprint. But let's get a 6.18
release out first, I'll send them for 6.19. There's also a lot more
work for the iclog_incore2 removal, including really nice cleanups
enabled by that.