From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: alternative take on the same page merging leak fix
Date: Thu, 13 Jun 2019 03:11:08 -0600 [thread overview]
Message-ID: <d0eb5ef0-4cb0-d2c0-7f5a-12830e916672@kernel.dk> (raw)
In-Reply-To: <20190613090257.GA13708@lst.de>
On 6/13/19 3:02 AM, Christoph Hellwig wrote:
> On Thu, Jun 13, 2019 at 03:02:10AM -0600, Jens Axboe wrote:
>>>> Patches 3 and 4 have no dependencies on 1 and 2, and should have
>>>> arguably been ordered first in the series.
>>>
>>> OK, that is good to make patch 3 &4 into 5.2, I will give a review
>>> soon.
>>
>> I'll echo Mings sentiments here, for the series.
>
> And what does that actually mean? Do you want me to just resend
> 3 and 4, or can you just pick them up?
Please resend them with the acks/reviews, I'll pick them up asap.
--
Jens Axboe
prev parent reply other threads:[~2019-06-13 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:10 alternative take on the same page merging leak fix Christoph Hellwig
2019-06-11 15:10 ` [PATCH 1/5] block: fix gap checking in __bio_add_pc_page Christoph Hellwig
2019-06-11 15:10 ` [PATCH 2/5] block: factor out a bio_try_merge_pc_page helper Christoph Hellwig
2019-06-11 15:10 ` [PATCH 3/5] block: return from __bio_try_merge_page if merging occured in the same page Christoph Hellwig
2019-06-12 10:14 ` Ming Lei
2019-06-11 15:10 ` [PATCH 4/5] block: fix page leak when merging to " Christoph Hellwig
2019-06-12 10:18 ` Ming Lei
2019-06-11 15:10 ` [PATCH 5/5] block: use __bio_try_merge_page in __bio_try_merge_pc_page Christoph Hellwig
2019-06-12 1:09 ` alternative take on the same page merging leak fix Ming Lei
2019-06-12 7:45 ` Christoph Hellwig
2019-06-12 10:11 ` Ming Lei
2019-06-13 9:02 ` Jens Axboe
2019-06-13 9:02 ` Christoph Hellwig
2019-06-13 9:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0eb5ef0-4cb0-d2c0-7f5a-12830e916672@kernel.dk \
--to=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox