* [PATCH] xfsprogs: define xfs_stack_trace() for debug builds
@ 2018-09-19 20:19 Eric Sandeen
2018-09-20 12:42 ` Bill O'Donnell
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2018-09-19 20:19 UTC (permalink / raw)
To: linux-xfs
Building with -DDEBUG fails due to lack of an xfs_stack_trace def'n.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
index 2f2ca06..b6746ca 100644
--- a/libxfs/libxfs_priv.h
+++ b/libxfs/libxfs_priv.h
@@ -118,6 +118,8 @@ enum ce { CE_DEBUG, CE_CONT, CE_NOTE, CE_WARN, CE_ALERT, CE_PANIC };
#define xfs_alert_tag(mp,tag,fmt,args...) cmn_err(CE_ALERT,fmt, ## args)
#define xfs_hex_dump(d,n) ((void) 0)
+#define xfs_stack_trace() ((void) 0)
+
#define xfs_force_shutdown(d,n) ((void) 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfsprogs: define xfs_stack_trace() for debug builds
2018-09-19 20:19 [PATCH] xfsprogs: define xfs_stack_trace() for debug builds Eric Sandeen
@ 2018-09-20 12:42 ` Bill O'Donnell
0 siblings, 0 replies; 2+ messages in thread
From: Bill O'Donnell @ 2018-09-20 12:42 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Wed, Sep 19, 2018 at 03:19:14PM -0500, Eric Sandeen wrote:
> Building with -DDEBUG fails due to lack of an xfs_stack_trace def'n.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
> index 2f2ca06..b6746ca 100644
> --- a/libxfs/libxfs_priv.h
> +++ b/libxfs/libxfs_priv.h
> @@ -118,6 +118,8 @@ enum ce { CE_DEBUG, CE_CONT, CE_NOTE, CE_WARN, CE_ALERT, CE_PANIC };
> #define xfs_alert_tag(mp,tag,fmt,args...) cmn_err(CE_ALERT,fmt, ## args)
>
> #define xfs_hex_dump(d,n) ((void) 0)
> +#define xfs_stack_trace() ((void) 0)
> +
>
> #define xfs_force_shutdown(d,n) ((void) 0)
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-20 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 20:19 [PATCH] xfsprogs: define xfs_stack_trace() for debug builds Eric Sandeen
2018-09-20 12:42 ` Bill O'Donnell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).