Re: [PATCH] xfs: Use xfs set and clear mp state helpers

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 7/10/2024 3:31 AM, John Garry wrote:
> Use the set and clear mp state helpers instead of open-coding.
> 
> It is noted that in some instances calls to atomic operation set_bit() and
> clear_bit() are being replaced with test_and_set_bit() and
> test_and_clear_bit(), respectively, as there is no specific helpers for
> set_bit() and clear_bit() only. However should be ok, as we are just
> ignoring the returned value from those "test" variants.
> 
> Signed-off-by: John Garry<john.g.garry@oracle.com>

This patch looks good to me, however formatting of the patch seems
little odd to me, what I meant is section describing the number of flies
changes and lines per file seems to be missing, e.g. (from different
patch) :-

"
---
  fs/xfs/scrub/trace.h |   10 ++++------
  fs/xfs/xfs_trace.h   |   10 ++++------
  2 files changed, 8 insertions(+), 12 deletions(-)
"

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck