From: Eric Sandeen <sandeen@sandeen.net>
To: Dan Melnic <dmm@fb.com>, "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>
Subject: Re: xfsprogs and libintl
Date: Thu, 3 Dec 2020 14:19:59 -0600 [thread overview]
Message-ID: <d3abd8ca-735d-d7d7-6229-e7540325cd84@sandeen.net> (raw)
In-Reply-To: <864CA3B9-B24E-4DB6-B87D-763E25DFF2FF@fb.com>
On 12/3/20 2:05 PM, Dan Melnic wrote:
> I guess this is an older version - 3.1.4:
That's ... 10 years old!
platform_defs.h has not been installed on the system since
2015 or so:
,commit dcabd4e7e955231a6bb92ce1038e62e5a9b90c5d
Author: Christoph Hellwig <hch@lst.de>
Date: Mon Aug 3 09:58:33 2015 +1000
xfsprogs: don't install platform_defs.h
> xfs.h includes platform_defs.h:
> #ifndef __XFS_H__
> #define __XFS_H__
>
> #include <xfs/platform_defs.h>
> #include <xfs/xfs_fs.h>
>
> #endif /* __XFS_H__ */
>
> Which:
>
> /* Define if you want gettext (I18N) support */
> /* #undef ENABLE_GETTEXT */
> #ifdef ENABLE_GETTEXT
> # include <libintl.h>
> # define _(x) gettext(x)
> # define N_(x) x
> #else
> # define _(x) (x)
> # define N_(x) x
> # define textdomain(d) do { } while (0)
> # define bindtextdomain(d,dir) do { } while (0)
> #endif
> #include <locale.h>
>
> I'll try to upgrade to a newer version then.
I think that is wise :)
-Eric
> Dan
next prev parent reply other threads:[~2020-12-03 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 19:15 xfsprogs and libintl Dan Melnic
2020-12-03 19:35 ` Darrick J. Wong
2020-12-03 20:05 ` Dan Melnic
2020-12-03 20:19 ` Eric Sandeen [this message]
2020-12-03 20:38 ` Dan Melnic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3abd8ca-735d-d7d7-6229-e7540325cd84@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=dmm@fb.com \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox