Re: [PATCH] xfsprogs: document attr2, ikeep option deprecation in xfs.5

[Eric Sandeen <sandeen@sandeen.net>]

On 3/2/21 7:45 AM, Pavel Reichl wrote:
> Since kernel v5.10, the (no)attr2 and (no)ikeep mount options are deprecated:
> 
> c23c393eaab5d xfs: remove deprecated mount options
> 
> Document this fact in the xfs(5) manpage.
> 
> Signed-off-by: Pavel Reichl <preichl@redhat.com>

Looks fine, thanks.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  man/man5/xfs.5 | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/man/man5/xfs.5 b/man/man5/xfs.5
> index 7642662f..b657f0e4 100644
> --- a/man/man5/xfs.5
> +++ b/man/man5/xfs.5
> @@ -118,6 +118,12 @@ to the file. Specifying a fixed allocsize value turns off
>  the dynamic behavior.
>  .TP
>  .BR attr2 | noattr2
> +Note: These options have been
> +.B deprecated
> +as of kernel v5.10; The noattr2 option will be removed no
> +earlier than in September 2025 and attr2 option will be immutable
> +default.
> +.sp
>  The options enable/disable an "opportunistic" improvement to
>  be made in the way inline extended attributes are stored
>  on-disk.  When the new form is used for the first time when
> @@ -159,6 +165,13 @@ across the entire filesystem rather than just on directories
>  configured to use it.
>  .TP
>  .BR ikeep | noikeep
> +Note: These options have been
> +.B deprecated
> +as of kernel v5.10; The noikeep option will be removed no
> +earlier than in September 2025 and ikeep option will be
> +immutable default.
> +
> +.sp
>  When ikeep is specified, XFS does not delete empty inode
>  clusters and keeps them around on disk.  When noikeep is
>  specified, empty inode clusters are returned to the free
>