[PATCH v22 00/16] Delayed Attributes

Allison Henderson
2021-07-27T06:21:13Z

Hi all,

This set is a subset of a larger series parent pointers. Delayed attributes allow
attribute operations (set and remove) to be logged and committed in the same
way that other delayed operations do. This allows more complex operations (like
parent pointers) to be broken up into multiple smaller transactions. To do
this, the existing attr operations must be modified to operate as a delayed
operation. This means that they cannot roll, commit, or finish transactions.
Instead, they return -EAGAIN to allow the calling function to handle the
transaction. In this series, we focus on only the delayed attribute portion.
We will introduce parent pointers in a later set.

The set as a whole is a bit much to digest at once, so I usually send out the
smaller sub series to reduce reviewer burn out. But the entire extended series
is visible through the included github links.

Updates since v21:

Added 3 new patches from Darrick's development tree:
xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process
xfs: refactor xfs_iget calls from log intent recovery
xfs: clear log incompat feature bits when the log is idle

xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process
Modified check to return 0, instead of error

xfs: Set up infrastructure for deferred attribute operations
Changed xattri_op_flags from uint32_t to unsigned int
Changed XFS_ATTR_OP_FLAGS_TYPE_MASK from 0x0FF to 0xFF
Removed comment from xfs_attri_item_size
Added error report in xfs_attri_copy_format
Variable nit cleanups in xfs_attri_item_committed
Added type masking to op_flag operations in xfs_attri_validate
Added XFS_ERROR_REPORT and -EFSCORRUPTED return in xlog_recover_attrd_commit_pass2(
Copyright time stamp update in xfs_attr_item.h
Rebase adjustments

xfs: Implement attr logging and replay
Added function xfs_sb_version_hasdelattr
Updated commit message per review comments
Added type masking to op_flag operations in xfs_trans_attr_finish_update
Moved incompat flag code to xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Added call to helper function xlog_recover_iget in xfs_attri_item_recover
Reworked attr in xfs_attri_item_recover to be allocated/freed
Added error check to xfs_defer_ops_capture_and_commit
Made xfs_trans_get_attrd and xfs_trans_attr_finish_update STATIC

xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Added helper function xfs_attr_use_log_assist
Added calls to helper function in xfs_attr_set
Fixed kernel test robot nits

xfs: Add delattr mount option
Added CONFIG_XFS_DEBUG check to mount option
Added Experimental warning to mount option

xfs: Add helper function xfs_attr_leaf_addname
Simplified error handling in xfs_attr_leaf_addname

Extended series updates:

xfs: Add parent pointers to rename
Added incompat flag logic to xfs_rename

xfs: remove parent pointers in unlink
Added incompat flag logic to xfs_unlink

xfs: add parent attributes to link
Added incompat flag logic to xfs_link

xfs: parent pointer attribute creation
Added incompat flag logic to xfs_create

This series can be viewed on github here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v22

As well as the extended delayed attribute and parent pointer series:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v22_extended

And the test cases:
https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv3
In order to run the test cases, you will need have the corresponding xfsprogs
changes as well. Which can be found here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v22
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v22_extended

To run the xfs attributes tests run:
check -g attr

To run as delayed attributes run:
export MOUNT_OPTIONS="-o delattr"
check -g attr

To run parent pointer tests:
check -g parent

I've also made the corresponding updates to the user space side as well, and ported anything
they need to seat correctly.

Questions, comment and feedback appreciated!

Allison

Allison Collins (1):
xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred

Allison Henderson (13):
xfs: refactor xfs_iget calls from log intent recovery
xfs: Return from xfs_attr_set_iter if there are no more rmtblks to
process
xfs: Add state machine tracepoints
xfs: Rename __xfs_attr_rmtval_remove
xfs: Handle krealloc errors in xlog_recover_add_to_cont_trans
xfs: Set up infrastructure for deferred attribute operations
xfs: Implement attr logging and replay
RFC xfs: Skip flip flags for delayed attrs
xfs: Remove unused xfs_attr_*_args
xfs: Add delayed attributes error tag
xfs: Add delattr mount option
xfs: Merge xfs_delattr_context into xfs_attr_item
xfs: Add helper function xfs_attr_leaf_addname

Darrick J. Wong (2):
xfs: allow setting and clearing of log incompat feature flags
xfs: clear log incompat feature bits when the log is idle

fs/xfs/Makefile | 1 +
fs/xfs/libxfs/xfs_attr.c | 435 +++++++++++----------
fs/xfs/libxfs/xfs_attr.h | 57 ++-
fs/xfs/libxfs/xfs_attr_leaf.c | 3 +-
fs/xfs/libxfs/xfs_attr_remote.c | 38 +-
fs/xfs/libxfs/xfs_attr_remote.h | 6 +-
fs/xfs/libxfs/xfs_defer.c | 1 +
fs/xfs/libxfs/xfs_defer.h | 3 +
fs/xfs/libxfs/xfs_errortag.h | 4 +-
fs/xfs/libxfs/xfs_format.h | 25 +-
fs/xfs/libxfs/xfs_log_format.h | 44 ++-
fs/xfs/libxfs/xfs_log_recover.h | 4 +
fs/xfs/scrub/common.c | 2 +
fs/xfs/xfs_attr_item.c | 835 ++++++++++++++++++++++++++++++++++++++++
fs/xfs/xfs_attr_item.h | 52 +++
fs/xfs/xfs_attr_list.c | 1 +
fs/xfs/xfs_bmap_item.c | 11 +-
fs/xfs/xfs_error.c | 3 +
fs/xfs/xfs_ioctl32.c | 2 +
fs/xfs/xfs_iops.c | 2 +
fs/xfs/xfs_log.c | 108 ++++++
fs/xfs/xfs_log.h | 4 +
fs/xfs/xfs_log_priv.h | 3 +
fs/xfs/xfs_log_recover.c | 54 ++-
fs/xfs/xfs_mount.c | 110 ++++++
fs/xfs/xfs_mount.h | 3 +
fs/xfs/xfs_ondisk.h | 2 +
fs/xfs/xfs_super.c | 11 +-
fs/xfs/xfs_trace.h | 25 ++
fs/xfs/xfs_xattr.c | 2 +
30 files changed, 1593 insertions(+), 258 deletions(-)
create mode 100644 fs/xfs/xfs_attr_item.c
create mode 100644 fs/xfs/xfs_attr_item.h

--
2.7.4