public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Carlos Maiolino <cem@kernel.org>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 1/4] iomap: add IOMAP_DIO_FSBLOCK_ALIGNED flag
Date: Wed, 29 Oct 2025 18:30:47 +1030	[thread overview]
Message-ID: <d5d33754-ecd3-43f0-a917-909cd1c2ab3e@suse.com> (raw)
In-Reply-To: <20251029074450.GB30412@lst.de>



在 2025/10/29 18:14, Christoph Hellwig 写道:
> On Tue, Oct 28, 2025 at 08:11:21AM +1030, Qu Wenruo wrote:
>> I'm wondering who should fix this part.
>>
>> The original author (myself) or Christoph?
> 
> Whoever resend it next :)
> 
> Unless you want to, I'll happily take care of it.

I'm totally fine if you can take care of it.

> 
> Any comments on my tweaks in the meantime?
> 

Patch 2 and 3 look good to me. Thank for catching the missing pos/length 
checks.

If you like you can even fold the fixes into this one.

Thanks,
Qu

  reply	other threads:[~2025-10-29  8:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 13:55 alloc misaligned vectors for zoned XFS Christoph Hellwig
2025-10-23 13:55 ` [PATCH 1/4] iomap: add IOMAP_DIO_FSBLOCK_ALIGNED flag Christoph Hellwig
2025-10-27 16:10   ` Darrick J. Wong
2025-10-27 21:41     ` Qu Wenruo
2025-10-27 21:56       ` Darrick J. Wong
2025-10-29  7:44       ` Christoph Hellwig
2025-10-29  8:00         ` Qu Wenruo [this message]
2025-10-29  8:15           ` Christoph Hellwig
2025-10-31 12:40             ` Christian Brauner
2025-10-23 13:55 ` [PATCH 2/4] FIXUP: iomap: aligning to larger than fs block size doesn't make sense Christoph Hellwig
2025-10-27 16:11   ` Darrick J. Wong
2025-10-23 13:55 ` [PATCH 3/4] FIXUP: iomap: also apply IOMAP_DIO_FSBLOCK_ALIGNED to the iomap range Christoph Hellwig
2025-10-27 16:12   ` Darrick J. Wong
2025-10-23 13:55 ` [PATCH 4/4] xfs: support sub-block aligned vectors in always COW mode Christoph Hellwig
2025-10-27 16:15   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5d33754-ecd3-43f0-a917-909cd1c2ab3e@suse.com \
    --to=wqu@suse.com \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=p.raghav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox