Re: [PATCH 01/12] fsstress: fix compiler warnings

[Allison Henderson <allison.henderson@oracle.com>]

On 11/22/18 10:58 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Fix all the gcc warnings in fsstress.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   ltp/fsstress.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index edbb3f2f..8d0734fc 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -499,7 +499,7 @@ int main(int argc, char **argv)
>   		exit(1);
>   	}
>   	if (logname) {
> -		char path[PATH_MAX];
> +		char path[PATH_MAX + NAME_MAX + 1];
>   		snprintf(path, sizeof(path), "%s/%s", rpath, logname);
>   		if (freopen(path, "a", stdout) == NULL) {
>   			perror("freopen logfile failed");
> @@ -583,7 +583,7 @@ int main(int argc, char **argv)
>   				return 0;
>   #endif
>   			if (logname) {
> -				char path[PATH_MAX];
> +				char path[PATH_MAX + NAME_MAX + 2 + 11];
>   				snprintf(path, sizeof(path), "%s/%s.%d",
>   					 rpath, logname, i);
>   				if (freopen(path, "a", stdout) == NULL) {
> 

Looks ok.  I'm assuming the 2 and the 11 are for the slash, dot and 
logname?  Maybe just a comment or two in the commit.  Otherwise looks 
good to me, you can add my review.  Thx!  :-)

Reviewed-By: Allison Henderson <allison.henderson@oracle.com>

Allison