linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Dormann <wdormann@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: Silent skipping of file during xfsrestore
Date: Mon, 28 Nov 2016 00:00:06 -0500	[thread overview]
Message-ID: <d669a091-dd58-6809-f18c-2fc796568a1d@gmail.com> (raw)
In-Reply-To: <20161128015956.GX28177@dastard>

Hi Dave,

On 11/27/16 8:59 PM, Dave Chinner wrote:
>> So what can cause a file to silently be skipped during restore?
> 
> Usually nothing. This is typical of xfsdump skipping a file due to
> some unexpected occurrence during backup. It's in the dump
> inventory as the directory was processed, but if somthing changed
> during the dump process (e.g. file gets replaced due to atomic
> overwrite via rename) then it may not end up being in the dump.

This file pretty much never gets written to after the first install of
the system, so I wouldn't suspect anything like that would have happened.


>> I'm
>> running the latest xfsdump/xfsrestore provided by Ubuntu 14.04, which is
>> 3.1.1.   I notice the same symptoms from my recovery environment, which
>> is SystemRescueCD 4.2.0
> 
> That's /old/. Try running the latest (3.1.6 IIRC) and see if that
> fixes the issue.


I tried running xfsrestore 3.1.6 on the existing 3.1.1 dump, and I got
the same symptoms:

---

 -> ls /etc/mythtv
            4032 session-settings
         4127166 session-settings~
        50343916 config.xml
         4884092 mysql.txt~

 -> add /etc/mythtv/config.xml

 -> extract

 --------------------------------- end dialog
---------------------------------

/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: mkdir etc
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: mkdir etc/mythtv
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: dump session label: ""
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: dump session id:
f132cc65-5bd4-4a58-a810-52398fe99326
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: stream 0, object 0, file 0
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: restoring non-directory files
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: media file 0 in object 0
of stream 0
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: restore complete: 207
seconds elapsed
/home/wd/in/xfsdump-3.1.6/restore/xfsrestore: Restore Status: SUCCESS



---

If the latest xfsrestore indicates that a file is in a backup, but then
doesn't actually restore it when asked, isn't that still indicative of a
problem?  That is, if xfsrestore indicates that a file is in a backup,
shouldn't it be restoring something?


I tried creating a new dump with 3.1.6, and subsequently restoring with
3.1.6, and it did succeed in restoring config.xml.

However, that may possibly have nothing to do with any sort of fix.
Because I couldn't restore config.xml when I did my system restore, I
had to create a new copy of it from a file-level backup.  Therefore, the
original problematic file isn't present anywhere other than my existing
xfsdump backups.



-WD


  reply	other threads:[~2016-11-28  5:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  1:49 Silent skipping of file during xfsrestore Will Dormann
2016-11-28  1:59 ` Dave Chinner
2016-11-28  5:00   ` Will Dormann [this message]
2016-11-28  8:21     ` Dave Chinner
2016-11-28 13:17       ` Will Dormann
2016-11-28 21:33         ` Dave Chinner
2016-11-28 22:00           ` Will Dormann
2016-11-28 16:10       ` Will Dormann
2016-11-28 16:32         ` Eric Sandeen
2016-11-28 16:43           ` Will Dormann
2016-11-28 17:45             ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d669a091-dd58-6809-f18c-2fc796568a1d@gmail.com \
    --to=wdormann@gmail.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).