linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 5/8] xfs: recheck reflink state after grabbing ILOCK_SHARED for a write
Date: Thu, 21 Jun 2018 23:35:38 -0700	[thread overview]
Message-ID: <d67f52df-2347-41d1-13c6-7411938ab99a@oracle.com> (raw)
In-Reply-To: <152960596196.26479.13083497192197135552.stgit@magnolia>

On 06/21/2018 11:31 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> In "xfs: fix fdblocks accounting w/ RMAPBT per-AG reservation", we fixed
> the per-ag reservation code so that we always decrease fdblocks by the
> reserved size because rmapbt blocks are counted as free space.
> 
> The primary symptom of this bug is that if the rmapbt has expanded since
> mount time, the disk block counters reported via statfs will change
> across a remount.  Therefore, we exercise this as a regression test.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   tests/xfs/712     |   62 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   tests/xfs/712.out |    1 +
>   tests/xfs/group   |    1 +
>   3 files changed, 64 insertions(+)
>   create mode 100755 tests/xfs/712
>   create mode 100644 tests/xfs/712.out

Humm, was there supposed to be more to this maybe?  Shouldn't we see a 
712.out somewhere?
> 
> 
> diff --git a/tests/xfs/712 b/tests/xfs/712
> new file mode 100755
> index 00000000..f90c7ec9
> --- /dev/null
> +++ b/tests/xfs/712
> @@ -0,0 +1,62 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2018 Oracle, Inc.  All rights reserved.
> +#
> +# FS QA Test No. 712
> +#
> +# Make sure that the statfs b_avail counter doesn't change across remount
> +# after the rmapbt has grown in size.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +	cd /
> +	rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remo
> 

  reply	other threads:[~2018-06-22  6:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 18:32 [PATCH 0/4] fstests: fixes and new tests Darrick J. Wong
2018-06-21 18:32 ` [PATCH 1/4] xfs/365: fuzz inobt in ag 1 Darrick J. Wong
2018-06-21 18:32 ` [PATCH 2/4] xfs: regression test for rmapbt fdblocks accounting problems Darrick J. Wong
2018-06-22  6:35   ` Allison Henderson [this message]
2018-06-22  6:39     ` [PATCH 5/8] xfs: recheck reflink state after grabbing ILOCK_SHARED for a write Darrick J. Wong
2018-06-22  6:40   ` [PATCH v2 2/4] xfs: regression test for rmapbt fdblocks accounting problems Darrick J. Wong
2018-06-21 18:32 ` [PATCH 3/4] generic: mread past eof shows nonzero contents Darrick J. Wong
2018-06-25  4:00   ` Eryu Guan
2018-06-25 15:34     ` Darrick J. Wong
2018-06-27  4:50       ` Eryu Guan
2018-06-21 18:32 ` [PATCH 4/4] xfs: fuzz every field of every structure and test kernel crashes Darrick J. Wong
2018-06-28  3:10   ` Eryu Guan
2018-06-28  4:31     ` Darrick J. Wong
2018-07-03 22:22     ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2018-06-21 18:31 [PATCH 0/8] xfs-4.18: various fixes Darrick J. Wong
2018-06-21 18:31 ` [PATCH 5/8] xfs: recheck reflink state after grabbing ILOCK_SHARED for a write Darrick J. Wong
2018-06-22  6:40   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d67f52df-2347-41d1-13c6-7411938ab99a@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).