Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Xin Gao <gaoxin@cdjrlc.com>, djwong@kernel.org
Cc: dchinner@redhat.com, chandan.babu@oracle.com,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Fix comment typo
Date: Fri, 22 Jul 2022 15:20:10 -0500	[thread overview]
Message-ID: <d8dfa68b-00d8-9853-e2ba-57c2bb54c05a@redhat.com> (raw)
In-Reply-To: <20220722193624.18002-1-gaoxin@cdjrlc.com>

On 7/22/22 2:36 PM, Xin Gao wrote:
> The double `for' is duplicated in line 3788, remove one.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  fs/xfs/libxfs/xfs_bmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 6833110d1bd4..6f6d87ba29a3 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3785,7 +3785,7 @@ xfs_bmapi_trim_map(
>  		mval->br_startblock = got->br_startblock +
>  					(*bno - got->br_startoff);
>  	/*
> -	 * Return the minimum of what we got and what we asked for for
> +	 * Return the minimum of what we got and what we asked for
>  	 * the length.  We can use the len variable here because it is
>  	 * modified below and we could have been there before coming
>  	 * here if the first part of the allocation didn't overlap what

NAK.

The comment is correct.


  reply	other threads:[~2022-07-22 20:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22 19:36 [PATCH] xfs: Fix comment typo Xin Gao
2022-07-22 20:20 ` Eric Sandeen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-22 19:43 Xin Gao
2022-07-22 20:20 ` Eric Sandeen
2022-07-22 19:40 Xin Gao
2022-07-22 19:32 Xin Gao
2022-07-22  2:26 Xin Gao
2022-07-22  2:46 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8dfa68b-00d8-9853-e2ba-57c2bb54c05a@redhat.com \
    --to=sandeen@redhat.com \
    --cc=chandan.babu@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=gaoxin@cdjrlc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox