Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Anand Jain <asj@kernel.org>
To: fstests@vger.kernel.org
Cc: zlang@kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 02/21] fstests: introduce _create_cloned_loop_devs() helper
Date: Tue,  6 Oct 2026 16:55:28 +0800	[thread overview]
Message-ID: <d97b87a346488157df940edbf89c62b71bbd0340.1791272793.git.asj@kernel.org> (raw)
In-Reply-To: <cover.1791272793.git.asj@kernel.org>

Introduce _create_cloned_loop_devs() and _destroy_cloned_loop_devs to mkfs an
image file and clone it to another image file, and attach a loop device to
them. And its destroy part.

Signed-off-by: Anand Jain <asj@kernel.org>
---
 common/rc | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/common/rc b/common/rc
index 7868e6d311a2..f2ab4bc491af 100644
--- a/common/rc
+++ b/common/rc
@@ -1534,6 +1534,72 @@ _scratch_resvblks()
 	esac
 }
 
+# Create a small loop image, run an optional tuning function ($2) on it,
+# clone it, and attach both to loop devices, returned in ($1).
+# Args:
+#   $1: Nameref to return the array of allocated loop devices [base, clone].
+#   $2: Optional callback function to tune the base filesystem before cloning.
+_create_cloned_loop_devs()
+{
+	local -n _ret=$1
+	local pre_clone_tune_func="$2"
+	local img_file="$TEST_DIR/${seq}/orig.img"
+	local img_file_clone="$TEST_DIR/${seq}/clone.img"
+	local size=$(_small_fs_size_mb 128) # Smallest possible
+	local temp_dev
+	local loop_devs=()
+
+	# All current callers mount the original and the clone simultaneously.
+	_require_clone_mount
+
+	# Since we copy the block device image, we keep its size small.
+	_require_fs_space $TEST_DIR $((size * 1024 * 2))
+
+	_create_file_sized $((size * 1024 * 1024)) $img_file ||
+				_fail "Failed: Create $img_file $size"
+
+	temp_dev=("$(_create_loop_device_like_bdev $img_file ${TEST_DEV})")
+	_mkfs_dev "${temp_dev}"
+
+	# Only execute if the function argument is not empty
+	if [ -n "$pre_clone_tune_func" ]; then
+		$pre_clone_tune_func "${temp_dev}"
+	fi
+
+	# We are about to copy the loop device's backing file
+	# Flush loop device's buffer cache
+	blockdev --flushbufs "${temp_dev}"
+	# Sync system's dirty pages including backing file's
+	sync
+	_destroy_loop_device "${temp_dev}"
+
+	cp $img_file $img_file_clone || _fail "Failed to copy cloned image"
+
+	loop_devs=("$(_create_loop_device_like_bdev $img_file ${TEST_DEV})")
+	loop_devs+=("$(_create_loop_device_like_bdev $img_file_clone ${TEST_DEV})")
+
+	# Help debug
+	losetup --list "${loop_devs[0]}" >> $seqres.full
+	losetup --list "${loop_devs[1]}" >> $seqres.full
+
+	_ret=("${loop_devs[@]}")
+}
+
+# Teardown loop devices and delete their underlying backing image files.
+# Accepts a list of loop device paths (e.g., /dev/loop0 /dev/loop1).
+_destroy_cloned_loop_devs()
+{
+	for d in "$@"; do
+		# Retrieve the path of the backing file
+		local f=$(losetup --noheadings --output BACK-FILE $d)
+
+		# Detach the loop device from the backing file
+		_destroy_loop_device "$d"
+
+		# Clean up the backing disk image file
+		[ -n "$f" ] && rm -f "$f"
+	done
+}
 
 # Repair scratch filesystem.  Returns 0 if the FS is good to go (either no
 # errors found or errors were fixed) and nonzero otherwise; also spits out
-- 
2.43.0


  parent reply	other threads:[~2026-10-06  8:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06  8:55 [PATCH 0/21] fstests: tests for cloned filesystem validation and f_fsid Anand Jain
2026-10-06  8:55 ` [PATCH 01/21] fstests: introduce _require_clone_mount() helper Anand Jain
2026-10-06  8:55 ` Anand Jain [this message]
2026-10-06  8:55 ` [PATCH 03/21] fstests: add _clone_mount_options() helper Anand Jain
2026-10-06  8:55 ` [PATCH 04/21] fstests: add FSNOTIFYWAIT_PROG Anand Jain
2026-10-06  8:55 ` [PATCH 05/21] fstests: add _require_fanotify_function Anand Jain
2026-10-06  8:55 ` [PATCH 06/21] fstests: add _require_unique_f_fsid() helper Anand Jain
2026-10-06  8:55 ` [PATCH 07/21] fstests: add SEMANAGE_PROG Anand Jain
2026-10-06  8:55 ` [PATCH 08/21] fstests: verify fanotify isolation on cloned filesystems Anand Jain
2026-10-06  8:55 ` [PATCH 09/21] fstests: introduce helper _scratch_mkfs_uuid() Anand Jain
2026-10-06  8:55 ` [PATCH 10/21] fstests: add helpers to verify the expected f_fsid Anand Jain
2026-10-06  8:55 ` [PATCH 11/21] fstests: verify statfs f_fsid is derived from the filesystem UUID Anand Jain
2026-10-06  8:55 ` [PATCH 12/21] fstests: verify libblkid resolution of duplicate UUIDs Anand Jain
2026-10-06  8:55 ` [PATCH 13/21] fstests: introduce _require_security_ima() helper Anand Jain
2026-10-06  8:55 ` [PATCH 14/21] fstests: verify IMA isolation on cloned filesystems Anand Jain
2026-10-06  8:55 ` [PATCH 15/21] fstests: verify exportfs file handles " Anand Jain
2026-10-06  8:55 ` [PATCH 16/21] fstests: introduce _require_metadata_uuid() helper Anand Jain
2026-10-06  8:55 ` [PATCH 17/21] fstests: add _change_metadata_uuid helper Anand Jain
2026-10-06  8:55 ` [PATCH 18/21] fstests: test UUID consistency for clones with metadata_uuid Anand Jain
2026-10-06  8:55 ` [PATCH 19/21] fstests: generic/744: use new helper _require_clone_mount() Anand Jain
2026-10-06  8:55 ` [PATCH 20/21] fstests: generic/744: migrate to _create_cloned_loop_devs() Anand Jain
2026-10-06  8:55 ` [PATCH 21/21] fstests: _create_loop_device_like_bdev() remove unused variable Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d97b87a346488157df940edbf89c62b71bbd0340.1791272793.git.asj@kernel.org \
    --to=asj@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox