* [PATCH] xfs: fix type usage
@ 2017-11-16 19:43 Darrick J. Wong
2017-11-16 19:45 ` Eric Sandeen
2017-11-17 16:47 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-11-16 19:43 UTC (permalink / raw)
To: xfs; +Cc: Eric Sandeen
From: Darrick J. Wong <darrick.wong@oracle.com>
Be consistent about using uint32_t/uint8_t instead of u32/u8. This is
more so that we don't have to maintain /those/ types in xfsprogs.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_iext_tree.c | 2 +-
fs/xfs/libxfs/xfs_log_format.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_iext_tree.c b/fs/xfs/libxfs/xfs_iext_tree.c
index 343a942..19e546a 100644
--- a/fs/xfs/libxfs/xfs_iext_tree.c
+++ b/fs/xfs/libxfs/xfs_iext_tree.c
@@ -302,7 +302,7 @@ xfs_iext_rec_cmp(
xfs_fileoff_t offset)
{
uint64_t rec_offset = rec->lo & XFS_IEXT_STARTOFF_MASK;
- u32 rec_len = rec->hi & XFS_IEXT_LENGTH_MASK;
+ uint32_t rec_len = rec->hi & XFS_IEXT_LENGTH_MASK;
if (rec_offset > offset)
return 1;
diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
index 996f035..349d9f8 100644
--- a/fs/xfs/libxfs/xfs_log_format.h
+++ b/fs/xfs/libxfs/xfs_log_format.h
@@ -274,7 +274,7 @@ struct xfs_inode_log_format {
uint64_t ilf_ino; /* inode number */
union {
uint32_t ilfu_rdev; /* rdev value for dev inode*/
- u8 __pad[16]; /* unused */
+ uint8_t __pad[16]; /* unused */
} ilf_u;
int64_t ilf_blkno; /* blkno of inode buffer */
int32_t ilf_len; /* len of inode buffer */
@@ -295,7 +295,7 @@ struct xfs_inode_log_format_32 {
uint64_t ilf_ino; /* inode number */
union {
uint32_t ilfu_rdev; /* rdev value for dev inode*/
- u8 __pad[16]; /* unused */
+ uint8_t __pad[16]; /* unused */
} ilf_u;
int64_t ilf_blkno; /* blkno of inode buffer */
int32_t ilf_len; /* len of inode buffer */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: fix type usage
2017-11-16 19:43 [PATCH] xfs: fix type usage Darrick J. Wong
@ 2017-11-16 19:45 ` Eric Sandeen
2017-11-17 16:47 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2017-11-16 19:45 UTC (permalink / raw)
To: Darrick J. Wong, xfs
On 11/16/17 1:43 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Be consistent about using uint32_t/uint8_t instead of u32/u8. This is
> more so that we don't have to maintain /those/ types in xfsprogs.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks Darrick.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/libxfs/xfs_iext_tree.c | 2 +-
> fs/xfs/libxfs/xfs_log_format.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_iext_tree.c b/fs/xfs/libxfs/xfs_iext_tree.c
> index 343a942..19e546a 100644
> --- a/fs/xfs/libxfs/xfs_iext_tree.c
> +++ b/fs/xfs/libxfs/xfs_iext_tree.c
> @@ -302,7 +302,7 @@ xfs_iext_rec_cmp(
> xfs_fileoff_t offset)
> {
> uint64_t rec_offset = rec->lo & XFS_IEXT_STARTOFF_MASK;
> - u32 rec_len = rec->hi & XFS_IEXT_LENGTH_MASK;
> + uint32_t rec_len = rec->hi & XFS_IEXT_LENGTH_MASK;
>
> if (rec_offset > offset)
> return 1;
> diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
> index 996f035..349d9f8 100644
> --- a/fs/xfs/libxfs/xfs_log_format.h
> +++ b/fs/xfs/libxfs/xfs_log_format.h
> @@ -274,7 +274,7 @@ struct xfs_inode_log_format {
> uint64_t ilf_ino; /* inode number */
> union {
> uint32_t ilfu_rdev; /* rdev value for dev inode*/
> - u8 __pad[16]; /* unused */
> + uint8_t __pad[16]; /* unused */
> } ilf_u;
> int64_t ilf_blkno; /* blkno of inode buffer */
> int32_t ilf_len; /* len of inode buffer */
> @@ -295,7 +295,7 @@ struct xfs_inode_log_format_32 {
> uint64_t ilf_ino; /* inode number */
> union {
> uint32_t ilfu_rdev; /* rdev value for dev inode*/
> - u8 __pad[16]; /* unused */
> + uint8_t __pad[16]; /* unused */
> } ilf_u;
> int64_t ilf_blkno; /* blkno of inode buffer */
> int32_t ilf_len; /* len of inode buffer */
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: fix type usage
2017-11-16 19:43 [PATCH] xfs: fix type usage Darrick J. Wong
2017-11-16 19:45 ` Eric Sandeen
@ 2017-11-17 16:47 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-11-17 16:47 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Eric Sandeen
On Thu, Nov 16, 2017 at 11:43:44AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Be consistent about using uint32_t/uint8_t instead of u32/u8. This is
> more so that we don't have to maintain /those/ types in xfsprogs.
Hmm.. The u* types are pretty common all over the kernel. They
probably will creep back eventually.. But if this is easier the
change is fine with me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-17 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-16 19:43 [PATCH] xfs: fix type usage Darrick J. Wong
2017-11-16 19:45 ` Eric Sandeen
2017-11-17 16:47 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).