From: John Garry <john.g.garry@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>, zlang@redhat.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/7] generic/767: allow on any atomic writes filesystem
Date: Mon, 4 Aug 2025 08:50:17 +0100 [thread overview]
Message-ID: <de5385b7-fc5f-43cf-9351-16024e3efd51@oracle.com> (raw)
In-Reply-To: <175381957992.3020742.8103178252494146518.stgit@frogsfrogsfrogs>
On 29/07/2025 21:09, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This test now works correctly for any atomic writes geometry since we
> control all the parameters. Remove this restriction so that we can get
> minimal testing on ext4 and fuse2fs.
The test comment reads "Validate multi-fsblock atomic write support with
simulated hardware support". Is that still true?
On another point, in checking generic/765, there still does seem to be
enough exclusive tests in 765 to make that test still have value.
>
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
Reviewed-by: John Garry <john.g.garry@oracle.com>
> tests/generic/767 | 1 -
> 1 file changed, 1 deletion(-)
>
>
> diff --git a/tests/generic/767 b/tests/generic/767
> index 161fef03825db4..558aab1e6acf34 100755
> --- a/tests/generic/767
> +++ b/tests/generic/767
> @@ -36,7 +36,6 @@ export SCRATCH_DEV=$dev
> unset USE_EXTERNAL
>
> _require_scratch_write_atomic
> -_require_scratch_write_atomic_multi_fsblock
>
> # Check that xfs_io supports the commands needed to run this test
> # Note: _require_xfs_io_command is not used here because we want to
>
>
next prev parent reply other threads:[~2025-08-04 7:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 20:08 [PATCHSET 1/3] fstests: fixes for atomic writes tests Darrick J. Wong
2025-07-29 20:08 ` [PATCH 2/7] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-07-30 14:18 ` Christoph Hellwig
2025-08-12 18:54 ` Darrick J. Wong
2025-08-13 5:15 ` Christoph Hellwig
2025-08-13 6:14 ` Darrick J. Wong
2025-08-13 6:24 ` Christoph Hellwig
2025-08-14 22:16 ` Darrick J. Wong
2025-08-18 4:37 ` Christoph Hellwig
2025-07-29 20:09 ` [PATCH 3/7] generic/767: require fallocate support Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 7:38 ` John Garry
2025-07-29 20:09 ` [PATCH 4/7] generic/767: only test the hardware atomic write unit Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 7:41 ` John Garry
2025-07-29 20:09 ` [PATCH 5/7] generic/767: allow on any atomic writes filesystem Darrick J. Wong
2025-08-01 18:56 ` Zorro Lang
2025-08-04 7:50 ` John Garry [this message]
2025-07-29 20:09 ` [PATCH 6/7] xfs/838: actually force usage of the realtime device Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 8:02 ` John Garry
2025-07-29 20:10 ` [PATCH 7/7] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-08-01 18:53 ` Zorro Lang
2025-08-27 18:04 ` Darrick J. Wong
2025-08-04 8:07 ` John Garry
2025-08-01 6:19 ` [PATCHSET 1/3] fstests: fixes for atomic writes tests Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5385b7-fc5f-43cf-9351-16024e3efd51@oracle.com \
--to=john.g.garry@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).