From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A314EB64DC for ; Thu, 20 Jul 2023 15:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232909AbjGTPpf (ORCPT ); Thu, 20 Jul 2023 11:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232907AbjGTPpe (ORCPT ); Thu, 20 Jul 2023 11:45:34 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A68CE; Thu, 20 Jul 2023 08:45:33 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80E0E22BD5; Thu, 20 Jul 2023 15:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689867932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTba3o2kPyRQo+UGixsLvGCxMe88Bb3EA6h99cQRtps=; b=qwJKksOHdTuFkyFwhRtlp1LxANP966bXCKrJEG+5m9/hdDiiLELUR8k5SWL+g+17AMoMtK PqZyd/GAZJVC3YADkrIKx2an4UXF5kowEwhjx7a5uCVUI7ReM58aktrYbnoxz9Lk0r4uIg WB/GEV9X7fnfP3XzO1YaywemMkiupKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689867932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTba3o2kPyRQo+UGixsLvGCxMe88Bb3EA6h99cQRtps=; b=q+mWssqwkd56oXHR8sXORz3ZI/rQgTF4jkb5FtlroAYjyypjl+qRCJT/9jX7clWCW5PTxq 1ZsMm3v6IGYwm6DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4689A133DD; Thu, 20 Jul 2023 15:45:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GrMgEJxWuWTvIAAAMHmgww (envelope-from ); Thu, 20 Jul 2023 15:45:32 +0000 Message-ID: Date: Thu, 20 Jul 2023 17:45:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-3-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230720140452.63817-3-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 7/20/23 16:04, Christoph Hellwig wrote: > block_page_mkwrite_return is neither block nor mkwrite specific, and > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > vmf_fs_error. > > Signed-off-by: Christoph Hellwig > --- > fs/ext4/inode.c | 2 +- > fs/f2fs/file.c | 2 +- > fs/gfs2/file.c | 16 ++++++++-------- > fs/iomap/buffered-io.c | 2 +- > fs/nilfs2/file.c | 2 +- > fs/udf/file.c | 2 +- > include/linux/buffer_head.h | 12 ------------ > include/linux/mm.h | 18 ++++++++++++++++++ > 8 files changed, 31 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman