From: Nikolay Borisov <nborisov@suse.com>
To: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: reduce memory allocation in the btrfs direct I/O path
Date: Thu, 5 May 2022 11:33:32 +0300 [thread overview]
Message-ID: <e96fcd60-7b2d-59f2-be72-a8f578afd583@suse.com> (raw)
In-Reply-To: <20220504162342.573651-1-hch@lst.de>
On 4.05.22 г. 19:23 ч., Christoph Hellwig wrote:
> Hi all,
>
> this series adds two minor improvements to iomap that allow btrfs
> to avoid a memory allocation per read/write system call and another
> one per submitted bio. I also have at last two other pending uses
> for the iomap functionality later on, so they are not really btrfs
> specific either.
>
> Diffstat:
> fs/btrfs/btrfs_inode.h | 25 --------
> fs/btrfs/ctree.h | 6 -
> fs/btrfs/file.c | 6 -
> fs/btrfs/inode.c | 152 +++++++++++++++++++++++--------------------------
> fs/iomap/direct-io.c | 26 +++++++-
> include/linux/iomap.h | 4 +
> 6 files changed, 104 insertions(+), 115 deletions(-)
>
Apart from the silent disk_bytenr removal nit:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2022-05-05 8:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:23 reduce memory allocation in the btrfs direct I/O path Christoph Hellwig
2022-05-04 16:23 ` [PATCH 1/5] iomap: allow the file system to provide a bio_set for direct I/O Christoph Hellwig
2022-05-05 15:38 ` Darrick J. Wong
2022-05-04 16:23 ` [PATCH 2/5] iomap: add per-iomap_iter private data Christoph Hellwig
2022-05-05 8:06 ` Nikolay Borisov
2022-05-05 15:06 ` Christoph Hellwig
2022-05-05 15:41 ` Darrick J. Wong
2022-05-05 15:45 ` Christoph Hellwig
2022-05-05 16:32 ` Darrick J. Wong
2022-05-05 18:15 ` Christoph Hellwig
2022-05-05 18:18 ` Darrick J. Wong
2022-05-04 16:23 ` [PATCH 3/5] btrfs: add a btrfs_dio_rw wrapper Christoph Hellwig
2022-05-04 16:23 ` [PATCH 4/5] btrfs: allocate dio_data on stack Christoph Hellwig
2022-05-04 16:23 ` [PATCH 5/5] btrfs: allocate the btrfs_dio_private as part of the iomap dio bio Christoph Hellwig
2022-05-05 8:12 ` Nikolay Borisov
2022-05-05 15:07 ` Christoph Hellwig
2022-05-05 15:20 ` David Sterba
2022-05-05 15:52 ` David Sterba
2022-05-05 8:33 ` Nikolay Borisov [this message]
2022-05-05 15:55 ` reduce memory allocation in the btrfs direct I/O path David Sterba
2022-05-06 17:18 ` Darrick J. Wong
2022-05-07 5:26 ` Christoph Hellwig
2022-05-09 18:46 ` David Sterba
2022-05-10 3:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e96fcd60-7b2d-59f2-be72-a8f578afd583@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox