linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Dormann <wdormann@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: Silent skipping of file during xfsrestore
Date: Mon, 28 Nov 2016 11:10:36 -0500	[thread overview]
Message-ID: <eaf5e5dc-5fa8-176b-7d39-47570ee7fd83@gmail.com> (raw)
In-Reply-To: <20161128082116.GA28177@dastard>

On 11/28/16 3:21 AM, Dave Chinner wrote:
> I think you misunderstand how the inventory and dump process
> works. The dump process first builds the inventory inode map that it
> needs to back up, then goes and backs up what it mapped in the
> inventory.  The filesystem can change between the inventory build
> an dump trying to backup the file, and if the file does not match
> the inventory for some reason (e.g. different inode generation
> number) it will skip it. The file does not get removed from the
> inventory, though, because that's already been written to the dump
> file.
> 
> There have also been situations where kernel bugs have meant xfsdump
> missed files. e.g. off-by-ones in bulkstat continuation code. These
> bugs had identical symptoms to what you are reporting, but given a
> new dump worked this is probably not the issue....


Another possible scenario that I'm wondering whether it's plausible:

My XFS filesystem was mildly corrupted (e.g. because of power failure or
other trouble).  But not in a way that was checked/noticed/corrected
automatically on system boot, or even had a noticeable effect on the
system other than the missing file on xfsrestore?

The system is back up and running, seemingly-fine.  But perhaps
obviously, my main concern here is to avoid this kind of scenario in the
future.   e.g., is there something I'm missing in my backup routine?
Silent failures on backup/restore are not very reassuring.



Thanks!
-WD

  parent reply	other threads:[~2016-11-28 16:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  1:49 Silent skipping of file during xfsrestore Will Dormann
2016-11-28  1:59 ` Dave Chinner
2016-11-28  5:00   ` Will Dormann
2016-11-28  8:21     ` Dave Chinner
2016-11-28 13:17       ` Will Dormann
2016-11-28 21:33         ` Dave Chinner
2016-11-28 22:00           ` Will Dormann
2016-11-28 16:10       ` Will Dormann [this message]
2016-11-28 16:32         ` Eric Sandeen
2016-11-28 16:43           ` Will Dormann
2016-11-28 17:45             ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaf5e5dc-5fa8-176b-7d39-47570ee7fd83@gmail.com \
    --to=wdormann@gmail.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).